Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some new mod interfaces #1811

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from
Open

some new mod interfaces #1811

wants to merge 14 commits into from

Conversation

Chzxxuanzheng
Copy link

@Chzxxuanzheng Chzxxuanzheng commented Dec 13, 2023

Please only submit Pull Requests to the dev branch!

Things to include in a large Pull Request:

  • What is the purpose of the pull request?

    Expand some new mod interfaces that is needed by our mod and now I can achieve.

  • Give a brief description of what you changed or added.

    • mod can define rainbow colour

    modify the Colour.java

    • mod can define response that is at phone

    modify the PhoneDialogue.java

    I only add some templates at mods. You can remove it.

    • mod can print error log

    put "System.err" into NashornScriptEngine

    • better support for js

    add some syntax for parse js
    add the js file that let mod save its data and update
    add some boring introduces in parse guide

  • Are any new graphical assets required?

    No

  • Has this change been tested? If so, mention the version number that the test was based on.

    openjdk 17.0.9 2023-10-17 LTS

  • So we have a better idea of who you are, what is your Discord Handle?

    Mr.Lee in Discord Handle

  • If you want quick feedback, you can use @Innoxia, or jump on the Lilith's Throne discord and send Innoxia a PM.

Mr.Lee added 14 commits December 12, 2023 18:43
some new syntax in parser:
{! don't parse #}
{# js code with return #}
{## js code without return #}

new method:
game.parseJsFromFile(String pathName)
parse js file
Util.getExternalModJsFilesById
get js file, such as getExternalModFilesById
mod can write its js code, and call it.

add new parse syntax to fix the question js' [] be regarded as command
{! don't parse #}
{# parse as js with return #}
{## parse as js without return #}

mod's js' data can be saved, and can update check when mod's version update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant