Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Expose InfomaniakDI as Framework #1550

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

PhilippeWeidmann
Copy link
Member

@PhilippeWeidmann PhilippeWeidmann commented Sep 20, 2024

As seen with tests on previous Xcode versions, Xcode 16 seems to also link differently Previews. With our current tuist configuration this leads to duplicate classes which causes problems with the DI singleton.

Copy link

sonarcloud bot commented Sep 20, 2024

Copy link
Member

@valentinperignon valentinperignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link

Found 2 unused code occurences

Expand
Mail/Views/CompactWindowDetectorModifier.swift:23:10: warning: Function 'detectCompactWindow()' is unused
Mail/Views/CompactWindowDetectorModifier.swift:28:8: warning: Struct 'CompactWindowDetectorModifier' is unused

@valentinperignon valentinperignon merged commit 3e0449c into master Sep 20, 2024
11 checks passed
@valentinperignon valentinperignon deleted the fix-preview-build branch September 20, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants