Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add a progress view when downloading swistransfer attachments #1547

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

feat: Add a progress view when downloading swistransfer attachments #1547

wants to merge 10 commits into from

Conversation

Matthieu-dgl
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 19, 2024 •
edited
Loading

Found 2 unused code occurences

Expand 
Mail/Views/CompactWindowDetectorModifier.swift:23:10: warning: Function 'detectCompactWindow()' is unused
Mail/Views/CompactWindowDetectorModifier.swift:28:8: warning: Struct 'CompactWindowDetectorModifier' is unused

@Matthieu-dgl Matthieu-dgl force-pushed the add-a-progress-view-when-downloading-swistransfer-attachments branch from 1e8f318 to 4a9e5f1 Compare September 19, 2024 08:21
@valentinperignon valentinperignon force-pushed the add-a-progress-view-when-downloading-swistransfer-attachments branch from 4a9e5f1 to 407aaa7 Compare September 19, 2024 08:34
@Matthieu-dgl Matthieu-dgl force-pushed the add-a-progress-view-when-downloading-swistransfer-attachments branch from 42c92b3 to 7a8ef8f Compare September 19, 2024 12:40
@Matthieu-dgl Matthieu-dgl changed the title Add a progress view when downloading swistransfer attachments featAdd a progress view when downloading swistransfer attachments Sep 19, 2024
@Matthieu-dgl Matthieu-dgl changed the title featAdd a progress view when downloading swistransfer attachments feat: Add a progress view when downloading swistransfer attachments Sep 19, 2024
@Matthieu-dgl Matthieu-dgl force-pushed the add-a-progress-view-when-downloading-swistransfer-attachments branch from 10f8ccb to 461829e Compare September 20, 2024 07:24
@valentinperignon valentinperignon force-pushed the add-a-progress-view-when-downloading-swistransfer-attachments branch from e318817 to 6b9d97d Compare September 20, 2024 07:49
valentinperignon
valentinperignon reviewed Sep 20, 2024
View reviewed changes
Copy link
Member

@valentinperignon valentinperignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a first review about the custom progressView 👍

MailCoreUI/Components/CircleIndeterminateProgressView.swift Outdated Show resolved Hide resolved
MailCoreUI/Components/CircleIndeterminateProgressView.swift Outdated Show resolved Hide resolved
MailCoreUI/Components/CircleIndeterminateProgressView.swift Outdated Show resolved Hide resolved
MailCoreUI/Components/CircleIndeterminateProgressView.swift Outdated Show resolved Hide resolved
MailCoreUI/Components/CircleIndeterminateProgressView.swift Outdated Show resolved Hide resolved
MailCoreUI/Components/CircleIndeterminateProgressView.swift Outdated Show resolved Hide resolved
@Matthieu-dgl Matthieu-dgl force-pushed the add-a-progress-view-when-downloading-swistransfer-attachments branch from f6caf68 to d9746f7 Compare September 20, 2024 11:33
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 20, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentinperignon valentinperignon valentinperignon left review comments

@PhilippeWeidmann PhilippeWeidmann Awaiting requested review from PhilippeWeidmann

At least 1 approving review is required to merge this pull request.

Assignees

@Matthieu-dgl Matthieu-dgl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Matthieu-dgl @valentinperignon