Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update message body loading logic #1542

Merged
merged 14 commits into from
Sep 18, 2024
Merged

feat: Update message body loading logic #1542

merged 14 commits into from
Sep 18, 2024

Conversation

valentinperignon
Copy link
Member

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 16, 2024 •
edited
Loading

Found 2 unused code occurences

Expand 
Mail/Views/CompactWindowDetectorModifier.swift:23:10: warning: Function 'detectCompactWindow()' is unused
Mail/Views/CompactWindowDetectorModifier.swift:28:8: warning: Struct 'CompactWindowDetectorModifier' is unused

@valentinperignon valentinperignon force-pushed the update-mail-loading-logic branch 3 times, most recently from 0f303a3 to bc70292 Compare September 17, 2024 11:41
@valentinperignon valentinperignon marked this pull request as ready for review September 17, 2024 11:41
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@adrien-coye
Copy link
Contributor

adrien-coye commented Sep 18, 2024 •
edited
Loading

I tested with my set of emails with inline images / threads, on device and simulator. All fine, nothing to report.

adrien-coye
adrien-coye approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just finished reviewing the code. It's all looking good. Nice job 👍

@valentinperignon valentinperignon merged commit 027c3ae into master Sep 18, 2024
8 checks passed
@valentinperignon valentinperignon deleted the update-mail-loading-logic branch September 18, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippeWeidmann PhilippeWeidmann PhilippeWeidmann approved these changes

@adrien-coye adrien-coye adrien-coye approved these changes

Assignees

@valentinperignon valentinperignon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@valentinperignon @adrien-coye @PhilippeWeidmann