Merge pull request #1036 from Infomaniak/debug-filelist

feat: Add Sentry breadcrumb on file collection changes
Infomaniak · Oct 17, 2023 · 7ee60a1 · 7ee60a1
2 parents 6c77b35 + 6e7a74d
commit 7ee60a1
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 0 deletions.
diff --git a/kDrive/UI/Controller/Files/File List/FileListViewController.swift b/kDrive/UI/Controller/Files/File List/FileListViewController.swift
@@ -383,7 +383,11 @@ class FileListViewController: UIViewController, UICollectionViewDataSource, Swip
     func updateFileList(deletions: [Int], insertions: [Int], modifications: [Int], moved: [(source: Int, target: Int)]) {
         guard !(deletions.isEmpty && insertions.isEmpty && modifications.isEmpty && moved.isEmpty) else { return }
 
+        let reloadId = UUID().uuidString
+
         collectionView.performBatchUpdates {
+            SentryDebug.updateFileListBreadcrumb(id: reloadId, step: "performBatchUpdates start")
+
             // Always apply updates in the following order: deletions, insertions, then modifications.
             // Handling insertions before deletions may result in unexpected behavior.
             collectionView.deleteItems(at: deletions.map { IndexPath(item: $0, section: 0) })
@@ -392,6 +396,9 @@ class FileListViewController: UIViewController, UICollectionViewDataSource, Swip
             for (source, target) in moved {
                 collectionView.moveItem(at: IndexPath(item: source, section: 0), to: IndexPath(item: target, section: 0))
             }
+            SentryDebug.updateFileListBreadcrumb(id: reloadId, step: "performBatchUpdates end")
+        } completion: { _ in
+            SentryDebug.updateFileListBreadcrumb(id: reloadId, step: "performBatchUpdates completion")
         }
         // Reload corners (outside of batch to prevent incompatible operations)
         reloadFileCorners(insertions: insertions, deletions: deletions)

diff --git a/kDrive/UI/Controller/Files/File List/FileListViewModel.swift b/kDrive/UI/Controller/Files/File List/FileListViewModel.swift
@@ -202,9 +202,11 @@ class FileListViewModel: SelectDelegate {
                 switch change {
                 case .initial(let results):
                     files = AnyRealmCollection(results)
+                    SentryDebug.filesObservationBreadcrumb(state: "initial")
                     onFileListUpdated?([], [], [], [], currentDirectory.fullyDownloaded && results.isEmpty, true)
                 case .update(let results, deletions: let deletions, insertions: let insertions, modifications: let modifications):
                     files = AnyRealmCollection(results)
+                    SentryDebug.filesObservationBreadcrumb(state: "update")
                     onFileListUpdated?(
                         deletions,
                         insertions,

diff --git a/kDriveCore/Utils/SentryDebug.swift b/kDriveCore/Utils/SentryDebug.swift
@@ -120,6 +120,18 @@ public enum SentryDebug {
         SentrySDK.addBreadcrumb(breadcrumb)
     }
 
+    public static func updateFileListBreadcrumb(id: String, step: String) {
+        let breadcrumb = Breadcrumb(level: .error, category: Category.uploadOperation)
+        breadcrumb.message = "updateFileList opId: \(id) step: \(step)"
+        SentrySDK.addBreadcrumb(breadcrumb)
+    }
+
+    public static func filesObservationBreadcrumb(state: String) {
+        let breadcrumb = Breadcrumb(level: .error, category: Category.uploadOperation)
+        breadcrumb.message = "files modified: \(state) "
+        SentrySDK.addBreadcrumb(breadcrumb)
+    }
+
     // MARK: - Upload notifications
 
     static func uploadNotificationError(_ metadata: [String: Any]) {