Split old setHtml method into independent basic logic components #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinBoulongne
requested changes
Jun 27, 2024
sample/src/main/java/com/infomaniak/lib/richhtmleditor/sample/EditorSampleFragment.kt
Outdated
Show resolved
Hide resolved
|
|
This PR/issue depends on:
|
KevinBoulongne
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setHtmlwas doing too many things and did not give enough freedom and control over the editor. All of what this method used to do has been split into independently callable methods.Now the content of the editor can be set by itself, the states can be subscribed to by themselves and the initial loading of the editor's HTML template is done as soon as possible
Depends on #20