When expanding a long Thread, display Messages by batches so it doesn't freeze the UI anymore #2044
Conversation
KevinBoulongne
force-pushed
the
open-thread-freeze
branch
2 times, most recently
from
4cf2c97
to
cc4cc09
Compare
KevinBoulongne
force-pushed
the
open-thread-freeze
branch
from
cc4cc09
to
5ff3762
Compare
| @@ -73,6 +73,7 @@ class ThreadViewModel @Inject constructor( | |||
|
|
|||
| val threadLive = MutableLiveData<Thread?>() | |||
| val messagesLive = MutableLiveData<Pair<ThreadAdapterItems, MessagesWithoutHeavyData>>() | |||
| val batchedMessages = SingleLiveEvent<List<Any>>() | |||
There was a problem hiding this comment.
Instead of having to rely in SingleLiveEvent can't we have a live data that represents the list of all loaded messages? This way we can listen in a straight forward manner to the list of messages, when the list updates, we submit the new list. The logic to delay the loading can then be handle on its own independently and the logic is not split depending on if we have more or less messages than ThreadViewModel.SUPER_COLLAPSED_BLOCK_MINIMUM_MESSAGES_LIMIT
| if (items.count() > ThreadViewModel.SUPER_COLLAPSED_BLOCK_MINIMUM_MESSAGES_LIMIT) { | ||
| displayBatchedMessages(items) | ||
| } else { | ||
| threadAdapter.submitList(items) | ||
| } |
There was a problem hiding this comment.
Can displayBatchedMessages() handle both cases inside by having the method automatically do less than SUPER_COLLAPSED_BLOCK_MINIMUM_MESSAGES_LIMIT if there's not enough items left?
KevinBoulongne
force-pushed
the
open-thread-freeze
branch
from
5ff3762
to
e0dc712
Compare
|
|
Why do we do all of this again though? |
In the situation of a Thread long enough so we display the SuperCollapsedBlock :