Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide discovery message when transfer list has at least one item #71

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LunarX
Copy link
Contributor

@LunarX LunarX commented Sep 20, 2024

Depends on #70

@LunarX LunarX requested a review from a team September 20, 2024 10:43
@LunarX LunarX self-assigned this Sep 20, 2024
@LunarX LunarX added the enhancement New feature or request label Sep 20, 2024
Copy link

sonarcloud bot commented Sep 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Base automatically changed from use-stringResource-over-getString to main September 20, 2024 10:54
Copy link

This PR/issue depends on:

@@ -52,7 +69,7 @@ fun ReceivedScreen(navigateToDetails: (transferId: Int) -> Unit) {
private fun ReceivedScreenMobilePreview() {
SwissTransferTheme {
Surface {
ReceivedScreen {}
ReceivedScreen { true }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ReceivedScreen { true }
ReceivedScreen(areTransfersEmpty = { true })

@@ -79,7 +80,7 @@ private fun ReceivedEmptyFabPreview() {
SwissTransferTheme {
Surface {
Row(Modifier.fillMaxSize(), horizontalArrangement = Arrangement.End, verticalAlignment = Alignment.Bottom) {
ReceivedEmptyFab()
ReceivedEmptyFab { true }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ReceivedEmptyFab { true }
ReceivedEmptyFab(isMessageVisible = { true })

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants