Add COG processing for large images #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlamanna
force-pushed
the
isic-123-add-cog-viewer
branch
from
76748d3
to
91a1ab0
Compare
danlamanna
force-pushed
the
isic-123-add-cog-viewer
branch
from
91a1ab0
to
b52745d
Compare
danlamanna
force-pushed
the
isic-123-add-cog-viewer
branch
7 times, most recently
from
7d51f76
to
889f4f6
Compare
brianhelba
reviewed
Jul 10, 2024
| stripped_blob_stream.seek(0) | ||
| accession_blob = self._generate_blob_as_cog(img) | ||
| else: | ||
| accession_blob = self._generate_blob(img) |
There was a problem hiding this comment.
Needs better function naming.
brianhelba
reviewed
Jul 10, 2024
isic/ingest/models/accession.py
Outdated
| is_cog=True, | ||
| ) | ||
| self.blob = accession_blob.blob | ||
| self._accession_blob_field.pre_save(self, add=False) |
brianhelba
reviewed
Jul 10, 2024
brianhelba
reviewed
Jul 10, 2024
brianhelba
reviewed
Jul 10, 2024
brianhelba
reviewed
Jul 10, 2024
brianhelba
reviewed
Jul 10, 2024
| self.blob = accession_blob.blob | ||
| self._accession_blob_field.pre_save(self, add=False) | ||
|
|
||
| return accession_blob |
There was a problem hiding this comment.
@brianhelba look at this
Suggested change
| return accession_blob | |
| yield accession_blob |
danlamanna
force-pushed
the
isic-123-add-cog-viewer
branch
4 times, most recently
from
a4f4f50
to
8d26809
Compare
danlamanna
commented
Jul 15, 2024
danlamanna
commented
Jul 15, 2024
danlamanna
force-pushed
the
isic-123-add-cog-viewer
branch
from
5d1f27b
to
1c480d5
Compare
danlamanna
force-pushed
the
isic-123-add-cog-viewer
branch
from
1c480d5
to
818f033
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related github.com/ImageMarkup/tracker/issues/123