Try fixing builds for pull-requests #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkaring
requested review from
brightrim and
estralis
and removed request for
estralis
|
I've been unable to set up a local environment for server dev, with the documentation lacking and Vilarion not around to provide any guidance. So I'm not able to do anything there if that is what you meant by pushing a local build. If on the other hand you mean pushing the build from the local side of the server itself somehow, only @estralis has access among our currently active devs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root cause of all problems, was a combination of the changes done to the permission system of Github along with a old bug in the GitHub Action that is used to determine the parameters and secrets of the repository.
With the initial fix in place, pull-requests are correctly detected and pushing of the pr build is disabled, as it should be.
Illarion-eV/Illarion-Docker-Version@master...feature/fix_pr_auth
The next steps I suggest is merging this and seeing if pushing the local build works fine. If it does, we'll create a new version of the GitHub Action and update the reference here from the sha pinned version to a new tagged version.