Release to Master ☘️ #604
Release to Master ☘️ #604
Conversation
divyanshu-rawat
commented
Mar 10, 2020
•
divyanshu-rawat
commented
- Folder restructuring. Issue: Folder structure refactoring. #579, PR: Folder Structure Refactor #602
- Service worker fixes ★.
- Common LogIn/SignUp UI. ★ Issue: Migration prop-Types => TS ★ #477, Write reusable code for login and sign up page #565. PR: feat: Migrate common-auth-student-prof files to TS #548.
- Navigator UI Added. Issue: Dashboard: Side Navigation #559, PR: dashboard ui:navigator added #593 🚀
- UI for Error Boundary. Issue: Error message UI fix. #578, PR: issue #578 Error message UI fix #598 🎉
…Design Feature/job confirmation design
divyanshu-rawat
temporarily deployed
to
ignitus-pipe-develop-ffzuyyaqu
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| import * as t from './constants'; | ||
| import '../Styles/style.scss'; | ||
|
|
||
| interface Props { |
There was a problem hiding this comment.
Parsing error: The keyword 'interface' is reserved
| @@ -0,0 +1,2 @@ | |||
| export const studentAuth: string = 'https://storage.googleapis.com/ignitus_assets/ig-assets/Assets_studentAuth.svg'; | |||
| import * as t from './constants'; | ||
| import '../Styles/style.scss'; | ||
|
|
||
| interface Props { |
There was a problem hiding this comment.
Parsing error: The keyword 'interface' is reserved
dashboard ui:navigator added
divyanshu-rawat
temporarily deployed
to
ignitus-pipe-develop-ffzuyyaqu
| font-weight: lighter; | ||
| } | ||
| .alert-danger { | ||
| background-color: rgb(238, 21, 14); |
There was a problem hiding this comment.
Color literals like rgb(238, 21, 14) should only be used in variable declarations; they should be referred to via variable everywhere else.
| text-align: center; | ||
| border-radius: 10px; | ||
| font-weight: lighter; | ||
| } |
There was a problem hiding this comment.
Rule declaration should be followed by an empty line
| } | ||
|
|
||
| .alert { | ||
| text-align: center; |
There was a problem hiding this comment.
Properties should be ordered border-radius, font-weight, text-align
|
|
||
| &:hover { | ||
| text-decoration: underline; | ||
| color: #060591; |
There was a problem hiding this comment.
Color literals like #060591 should only be used in variable declarations; they should be referred to via variable everywhere else.
| font-weight: bolder; | ||
|
|
||
| &:hover { | ||
| text-decoration: underline; |
There was a problem hiding this comment.
Properties should be ordered color, text-decoration
| } | ||
|
|
||
| .btn-linkedin { | ||
| background: #010071; |
There was a problem hiding this comment.
Color literals like #010071 should only be used in variable declarations; they should be referred to via variable everywhere else.
|
|
||
| .container-image { | ||
| background: $ignite-color-blue-97; | ||
| border: 1px solid #fac76f; |
There was a problem hiding this comment.
Color literals like #fac76f should only be used in variable declarations; they should be referred to via variable everywhere else.
| // border-radius: 0px 0px 0px 15px; | ||
| } | ||
|
|
||
| .text-below-image { |
There was a problem hiding this comment.
Merge rule .text-below-image with rule on line 84
|
|
||
| .text-below-image { | ||
| background-color: $ignite-color-blue-97; | ||
| flex-basis: 43%; |
There was a problem hiding this comment.
Properties should be ordered background-color, border, flex-basis
| } | ||
|
|
||
| .loader { | ||
| display: flex; |
There was a problem hiding this comment.
Properties should be ordered align-items, display, height, justify-content, width
divyanshu-rawat
added
enhancement
* issue #578 Error message UI fix * issue #578 Error message UI fix line break added * issue #578 details tab align * minor changes #578 * minor fixes #578 * corrections #578 * for review 578 * padding changed * code quality * line break added * edit * edit 2 * Update CONTRIBUTION.md * Update CONTRIBUTION.md * margin added * space removed * api link corrected * details link corrected * final correction * resolved conflicts & enhanced text message 🔨 Co-authored-by: Divyanshu Rawat <[email protected]>
divyanshu-rawat
temporarily deployed
to
ignitus-pipe-develop-ffzuyyaqu
| } | ||
|
|
||
| .button-bg:hover { | ||
| background: #060591; |
There was a problem hiding this comment.
Color literals like #060591 should only be used in variable declarations; they should be referred to via variable everywhere else.
|
|
||
| .button-bg { | ||
| background: #010071; | ||
| border-color: #010071; |
There was a problem hiding this comment.
Color literals like #010071 should only be used in variable declarations; they should be referred to via variable everywhere else.
| } | ||
|
|
||
| .button-bg { | ||
| background: #010071; |
There was a problem hiding this comment.
Color literals like #010071 should only be used in variable declarations; they should be referred to via variable everywhere else.
| } | ||
|
|
||
| .email-border { | ||
| border-radius: 0 10px 10px 0; |
There was a problem hiding this comment.
Shorthands of length 4 are not allowed. Value was 0 10px 10px 0
| } | ||
|
|
||
| .password-border { | ||
| border-radius: 0 10px 10px 0; |
There was a problem hiding this comment.
Shorthands of length 4 are not allowed. Value was 0 10px 10px 0
|
|
||
| .container-custom { | ||
| max-width: 800px; | ||
| margin-top: 0px; |
There was a problem hiding this comment.
0px should be written without units as 0
| @import './ignitus-tokens.scss'; | ||
|
|
||
| .container-custom { | ||
| max-width: 800px; |
There was a problem hiding this comment.
Properties should be ordered margin-left, margin-right, margin-top, max-width
| @@ -0,0 +1,158 @@ | |||
| // import ignitus token variables | |||
| @import './ignitus-tokens.scss'; | |||
There was a problem hiding this comment.
Imported partial ./ignitus-tokens.scss should be written as ./ignitus-tokens
Prefer double-quoted strings
| background-color: $ignite-color-blue-bg; | ||
| color: $ignite-color-white; | ||
| } | ||
| .option:hover svg g rect { |
There was a problem hiding this comment.
Merge rule .option:hover svg g rect with rule on line 29
Selector should have depth of applicability no greater than 2, but was 4
| .option:hover { | ||
| background-color: $ignite-color-blue-bg; | ||
| color: $ignite-color-white; | ||
| } |
There was a problem hiding this comment.
Rule declaration should be followed by an empty line
divyanshu-rawat
temporarily deployed
to
ignitus-pipe-develop-ffzuyyaqu
| margin-right: 25px; | ||
| } | ||
|
|
||
| svg g rect { |
There was a problem hiding this comment.
Merge rule svg g rect with rule on line 21
Selector should have depth of applicability no greater than 2, but was 3
| font-weight: bold; | ||
| color: $ignite-color-blue-bg; | ||
| padding: 10px 30px; | ||
| } |
There was a problem hiding this comment.
Rule declaration should be followed by an empty line
| padding: 20px 0; | ||
| } | ||
| .option { | ||
| font-size: 16px; |
There was a problem hiding this comment.
Properties should be ordered color, font-size, font-weight, padding
| box-shadow: 0px 3px 6px rgba(0, 0, 0, 0.1); | ||
| border-radius: 16px; | ||
| padding: 20px 0; | ||
| } |
There was a problem hiding this comment.
Rule declaration should be followed by an empty line
| left: 75px; | ||
| top: 145px; | ||
| background: $ignite-color-white; | ||
| box-shadow: 0px 3px 6px rgba(0, 0, 0, 0.1); |
There was a problem hiding this comment.
Color literals like rgba(0, 0, 0, 0.1) should only be used in variable declarations; they should be referred to via variable everywhere else.0px should be written without units as 0
| @import '../../styles/ignitus-tokens.scss'; | ||
|
|
||
| .navigator { | ||
| position: absolute; |
There was a problem hiding this comment.
Properties should be ordered background, border-radius, box-shadow, height, left, padding, position, top, width
| @@ -0,0 +1,35 @@ | |||
| @import '../../styles/ignitus-components-common.scss'; | |||
| @import '../../styles/ignitus-tokens.scss'; | |||
There was a problem hiding this comment.
Imported partial ../../styles/ignitus-tokens.scss should be written as ../../styles/ignitus-tokens
Prefer double-quoted strings
| @@ -0,0 +1,35 @@ | |||
| @import '../../styles/ignitus-components-common.scss'; | |||
There was a problem hiding this comment.
Imported partial ../../styles/ignitus-components-common.scss should be written as ../../styles/ignitus-components-common
Prefer double-quoted strings
divyanshu-rawat
temporarily deployed
to
ignitus-pipe-develop-ffzuyyaqu
