-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/tags for elasticsearchwriter #10074
Open
SebastianOpeni
wants to merge
10
commits into
Icinga:master
Choose a base branch
from
open-i-gmbh:feature/tags-for-elasticsearchwriter-6837
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
df78b30
Add tags fuctionality to ElasticSearchWriter
SebastianOpeni b844e81
Documentation for tags fuctionality in ElasticSearchWriter
SebastianOpeni 2f3c2fa
Update AUTHORS
SebastianOpeni 6cd12c0
Change variable names to camel Case and rearange Block/Scopes
SebastianOpeni 4c959e2
Remove Entry from .mailmap
SebastianOpeni 99a4dc4
Corrected indents
SebastianOpeni 3ad4c9d
doc/14-features.md: correct Elasticsearch versions
Al2Klimov 3b3b435
Merge pull request #2 from Al2Klimov/patch-2
SebastianOpeni c661ba2
Add ElasticSearch tags to root element instaed of a dictionary-field
SebastianOpeni 468c7d0
Add host tags template only for host checks
SebastianOpeni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -255,6 +255,7 @@ Sascha Westermann <[email protected]> | |
Sebastian Brückner <[email protected]> | ||
Sebastian Chrostek <[email protected]> | ||
Sebastian Eikenberg <[email protected]> | ||
Sebastian Grund <[email protected]> | ||
Sebastian Marsching <[email protected]> | ||
Silas <[email protected]> | ||
Simon Murray <[email protected]> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not quite sure if
tags
is the right field for this. Isn't it common thattags
is just a simple list instead of key-value pairs? I would set a different field or make it configureable.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The field
tags
as a dictionary was used because the influxdb-writer is also using it that way.The functionality would stay the same with a different field name so if you have a preference I could change it accordingly.
(
labels
would come to mind as a alternative.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gave it some thought and I could also simply allow tags to be of type array. (in addition to dict)
That would change some of the logic we had reviewed until now but if that would be preferred by you, I could also implement it that way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid, in perfdata DB context, they indeed are key-value pairs:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please show me where we set a field called
tags
in one of them. Supporting tags in both just means adding key-value pairs, with no reference to atags
field, right?. But here we set the field where I wonder if users of Elasticsearch or similar would expect a list rather than key-value pairs.tag_set
sounds more reasonable to me. Anyway, before we just merge this, I'd like to get an informed opinion.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But
tags
never reaches Influx DB.Otherwise there would not be a
tags
field either.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found it as well just after Commenting. 🙈
That was my bad.
I'm very sorry for the confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To prevent confusion about the Type of
tags
, would you prefer to:tag_set
orThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a tag_set property would be rather confusing in ES/Kibana.
This, in contrast, has the advantages:
tags.
boilerplate in our ES dataThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After my changes the configured tags are now added to the root element.
That also allows for
tags = ["foo", "bar"]
if desired.Notice:
Since the templated_tags are added after the default fields and the performance Values this change will also allow to overwrite them.