explicitly namespace dopar transxchange try calls #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I've merged. I would like to get this on CRAN one day but there is a lot of cleaning to do including fixing up the parallel processing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mem48 Thanks for this awesome package! This PR fixes a bug that will affect some systems (including mine, on which the main functions do not work). The workers spawned by
doparcalls won't necessarily have the package loaded, dependent on complex interactions between OS and multi-threading libraries, so it's always important to explicitly namespace functions called. Your calls here are to internal functions, which require:::notation, but as I guess this package is not intended to get to CRAN (right?), that should be acceptable. Happy to discuss alternatives if you prefer.