-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed incorrect behavior of :BlockedApiPolicy #9742 #9747
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://dataverse-guide--9747.org.readthedocs.build/en/9747/installation/config.html#blocking-api-endpoints looks good to me! Approved.
Here's a screenshot:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this specific to nginx? if so, should we make a note of that?
@cesarpferreira thanks for the pull request! Please note the question above by @donsizemore. Thanks! |
@donsizemore that is a good question. We were doing some tests with haproxy in one installation, but it had the host IP address so it was working correctly. I can try to change it to localhost and check if this happens |
Just confirmed, it also happens with haproxy and this situation is most common when you only have one server behind the reverse proxy service and it is easier to set up the backend as localhost. |
Does that mean we're ok with the pull request as-is? Or should @cesarpferreira add an additional note? (@cesarpferreira please feel free to add more if you like!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We just talked about this at standup. @donsizemore and I are happy with it as-is so I'm moving it to QA.
What this PR does / why we need it:
Documentation from our findings when solving an issue related to incorrect behavior of the policy to block API access.
Which issue(s) this PR closes:
Closes #9742
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
No.
Additional documentation: