Releasing versioned (base) images #10827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For scheduled maintenance, we will provide updates to the last three base images as well as the develop branch.
Checkout the branch/tag we receive from the discovery job
…from Maven Using Maven properties, we find out which is the projects preferred Java version. We don't need a build matrix here.
We no longer work on PRs in this workflow, so we don't need to safeguard against not running steps in this case.
We no longer work on PRs in this workflow, so we don't need to safeguard against not running steps in this case. Also we no longer use the static image names, but rely on the truth Maven has in the container-base module about the version of the image.
… push to Docker Hub
Fix jq output by removing newlines and superfluous whitespace.
…ep from XML instead
…which is compatible with the v6.2 image
…cceed We use the branch name from the matrix as input argument. It's not being used yet.
…se image workflow
Deleted by accident when working on alternativ matrix way to build app image after base.
- Enable -Ddocker.noCache for BuildX - Hopefully straightens out some bugs on Darwin with M1/M2
This way we have a distinct path and name to inject a BuildX builder instance configuration
Before, we would have run the workflow for develop only. In case develop has merges before the run starts because of a tag being created, this may result in undesired side effects. Keep in mind that pushes of tags here will also trigger releasing a new application image!
Can be picked up by other jobs, e.g. to create textblocks for docs or a job matrix.
poikilotherm
force-pushed
the
10478-version-base-img
branch
from
d7e4a05
to
883668e
Compare
poikilotherm
force-pushed
the
10478-version-base-img
branch
from
883668e
to
1301020
Compare
…kflow We did not correctly compare the status code of the grep command, breaking the update detection
…ance job As discussed during community meeting on 2024-09-19.
poikilotherm
force-pushed
the
10478-version-base-img
branch
from
4b652a6
to
4528494
Compare
Re-enable and change everything necessary to reference the upstream IQSS context as of now.
poikilotherm
force-pushed
the
10478-version-base-img
branch
from
192f254
to
9b9ab10
Compare
Without this in case of the pull_request event the input is null and the build fails because we have base image defined at all. Simply not adding the option if the input is undefined means we stick to what is defined within the POM.
pdurbin
reviewed
Sep 19, 2024
…n props Co-authored-by: Philip Durbin <[email protected]>
pdurbin
approved these changes
Sep 20, 2024
This was referenced Sep 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We want to release versioned tags of the base image (and eventually the application images, too).
This requires setting up different versioning within the POM files, a better maintenance workflow to keep images updated and coordination between connected workflows.
Which issue(s) this PR closes:
Special notes for your reviewer:
Open TODOs to call this done:
Suggestions on how to test this:
All testing can only be done in the fork, as most of the workflows must be on the default branch to test them.
This has been done thoroughly, but there may be other non-testable edge cases we will only trip over once merged.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
Probably.
Additional documentation:
Preview docs at https://dataverse-guide--10827.org.readthedocs.build/en/10827/container/base-image.html