Add missing @OverRide annotations

modules/dataverse-spi/src/main/java/io/gdcc/spi/export/XMLExporter.java

@@ -31,6 +31,7 @@ public interface XMLExporter extends Exporter {
     /**
      * @return - should always be MediaType.APPLICATION_XML
      */
+    @Override
     public default String getMediaType() {
         return MediaType.APPLICATION_XML;
     }

src/main/java/edu/harvard/iq/dataverse/ControlledVocabularyValueConverter.java

@@ -22,6 +22,7 @@ public class ControlledVocabularyValueConverter implements Converter {
     //@EJB
     DatasetFieldServiceBean datasetFieldService = CDI.current().select(DatasetFieldServiceBean.class).get();
 
+    @Override
     public Object getAsObject(FacesContext facesContext, UIComponent component, String submittedValue) {
         if (submittedValue == null || submittedValue.equals("")) {
             return "";

src/main/java/edu/harvard/iq/dataverse/DatasetFieldType.java

@@ -470,12 +470,14 @@ public boolean isHasParent() {
         return this.parentDatasetFieldType != null;
     }
 
+    @Override
     public int hashCode() {
         int hash = 0;
         hash += (this.id != null ? this.id.hashCode() : 0);
         return hash;
     }
 
+    @Override
     public boolean equals(Object object) {
         // TODO: Warning - this method won't work in the case the id fields are not set
         if (!(object instanceof DatasetFieldType)) {

src/main/java/edu/harvard/iq/dataverse/DatasetFieldValueValidator.java

@@ -27,10 +27,12 @@ public class DatasetFieldValueValidator implements ConstraintValidator<ValidateD
     private static final Logger logger = Logger.getLogger(DatasetFieldValueValidator.class.getCanonicalName());
 
     //private String fieldType;
+    @Override
     public void initialize(ValidateDatasetFieldType constraintAnnotation) {
         //this.fieldType = constraintAnnotation.value();
     }
 
+    @Override
     public boolean isValid(DatasetFieldValue value, ConstraintValidatorContext context) {
         context.disableDefaultConstraintViolation(); // we do this so we can have different messages depending on the different issue
 

src/main/java/edu/harvard/iq/dataverse/DatasetVersionUI.java

@@ -370,6 +370,7 @@ private List<DatasetField> initDatasetFields(boolean createBlanks) {
 
         //sort via display order on dataset field
         Collections.sort(retList, new Comparator<DatasetField>() {
+            @Override
             public int compare(DatasetField d1, DatasetField d2) {
                 int a = d1.getDatasetFieldType().getDisplayOrder();
                 int b = d2.getDatasetFieldType().getDisplayOrder();
@@ -382,6 +383,7 @@ public int compare(DatasetField d1, DatasetField d2) {
 
     private List<DatasetField> sortDatasetFields(List<DatasetField> dsfList) {
         Collections.sort(dsfList, new Comparator<DatasetField>() {
+            @Override
             public int compare(DatasetField d1, DatasetField d2) {
                 int a = d1.getDatasetFieldType().getDisplayOrder();
                 int b = d2.getDatasetFieldType().getDisplayOrder();

src/main/java/edu/harvard/iq/dataverse/FacetConverter.java

@@ -22,6 +22,7 @@ public class FacetConverter implements Converter {
     //@EJB
     DatasetFieldServiceBean datasetFieldService = CDI.current().select(DatasetFieldServiceBean.class).get();
 
+    @Override
     public Object getAsObject(FacesContext facesContext, UIComponent component, String submittedValue) {
         return datasetFieldService.find(Long.valueOf(submittedValue));
     }

src/main/java/edu/harvard/iq/dataverse/GlobalId.java

@@ -69,6 +69,7 @@ public String getProviderId() {
         return managingProviderId;
     }
 
+    @Override
     public String toString() {
         return asString();
     }

src/main/java/edu/harvard/iq/dataverse/MetadataBlockConverter.java

@@ -22,6 +22,7 @@ public class MetadataBlockConverter implements Converter {
     //@EJB
     DataverseServiceBean dataverseService = CDI.current().select(DataverseServiceBean.class).get();
 
+    @Override
     public Object getAsObject(FacesContext facesContext, UIComponent component, String submittedValue) {
         return dataverseService.findMDB(Long.valueOf(submittedValue));
     }

src/main/java/edu/harvard/iq/dataverse/RoleAssigneeConverter.java

@@ -24,6 +24,7 @@ public class RoleAssigneeConverter implements Converter {
     //@EJB
     RoleAssigneeServiceBean roleAssigneeService = CDI.current().select(RoleAssigneeServiceBean.class).get();
 
+    @Override
     public Object getAsObject(FacesContext facesContext, UIComponent component, String submittedValue) {
         return roleAssigneeService.getRoleAssignee(submittedValue);
     }

src/main/java/edu/harvard/iq/dataverse/Template.java

@@ -225,6 +225,7 @@ private List<DatasetField> initDatasetFields() {
 
         //sort via display order on dataset field
         Collections.sort(retList, new Comparator<DatasetField>() {
+            @Override
             public int compare(DatasetField d1, DatasetField d2) {
                 int a = d1.getDatasetFieldType().getDisplayOrder();
                 int b = d2.getDatasetFieldType().getDisplayOrder();
@@ -237,6 +238,7 @@ public int compare(DatasetField d1, DatasetField d2) {
 
     private List<DatasetField> sortDatasetFields(List<DatasetField> dsfList) {
         Collections.sort(dsfList, new Comparator<DatasetField>() {
+            @Override
             public int compare(DatasetField d1, DatasetField d2) {
                 int a = d1.getDatasetFieldType().getDisplayOrder();
                 int b = d2.getDatasetFieldType().getDisplayOrder();

src/main/java/edu/harvard/iq/dataverse/api/Admin.java

@@ -2024,6 +2024,7 @@ public Response submitDatasetVersionToArchive(@Context ContainerRequestContext c
                         }
                     }
                     new Thread(new Runnable() {
+                        @Override
                         public void run() {
                             try {
                                 DatasetVersion dv = commandEngine.submit(cmd);
@@ -2101,6 +2102,7 @@ public Response archiveAllUnarchivedDatasetVersions(@Context ContainerRequestCon
                 if (cmd != null) {
                     //Found an archiver to use
                     new Thread(new Runnable() {
+                        @Override
                         public void run() {
                             int total = dsl.size();
                             int successes = 0;

src/main/java/edu/harvard/iq/dataverse/api/auth/WrappedAuthErrorResponse.java

@@ -20,6 +20,7 @@ public WrappedAuthErrorResponse(String message) {
                 ).type(MediaType.APPLICATION_JSON_TYPE).build();
     }
 
+    @Override
     public String getMessage() {
         return this.message;
     }

src/main/java/edu/harvard/iq/dataverse/authorization/providers/oauth2/impl/MicrosoftOAuth2AP.java

@@ -53,6 +53,7 @@ protected ParsedUserResponse parseUserResponse(final String responseBody) {
         }
     }
 
+    @Override
     public boolean isDisplayIdentifier()
     {
         return false;

src/main/java/edu/harvard/iq/dataverse/authorization/users/AuthenticatedUser.java

@@ -508,6 +508,7 @@ public String toString() {
         return "[AuthenticatedUser identifier:" + getIdentifier() + "]";
     }
 
+    @Override
     public String getSortByString() {
         return this.getLastName() + " " + this.getFirstName() + " " + this.getUserIdentifier();
     }

src/main/java/edu/harvard/iq/dataverse/dataaccess/RemoteOverlayAccessIO.java

@@ -288,6 +288,7 @@ public boolean downloadRedirectEnabled() {
         return false;
     }
 
+    @Override
     public boolean downloadRedirectEnabled(String auxObjectTag) {
         return baseStore.downloadRedirectEnabled(auxObjectTag);
     }

src/main/java/edu/harvard/iq/dataverse/dataaccess/S3AccessIO.java

@@ -867,6 +867,7 @@ public boolean downloadRedirectEnabled() {
         return false;
     }
 
+    @Override
     public boolean downloadRedirectEnabled(String auxObjectTag) {
         return downloadRedirectEnabled();
     }
@@ -880,6 +881,7 @@ public boolean downloadRedirectEnabled(String auxObjectTag) {
      * @return redirect url
      * @throws IOException.
      */
+    @Override
     public String generateTemporaryDownloadUrl(String auxiliaryTag, String auxiliaryType, String auxiliaryFileName) throws IOException {
         //Questions:
         // Q. Should this work for private and public?

src/main/java/edu/harvard/iq/dataverse/dataaccess/TabularSubsetGenerator.java

@@ -76,10 +76,12 @@ public TabularSubsetGenerator() {
      * Please consult git history if you are interested in looking at that code. 
      */
 
+    @Override
     public void subsetFile(String infile, String outfile, List<Integer> columns, Long numCases) {
         subsetFile(infile, outfile, columns, numCases, "\t");
     }
 
+    @Override
     public void subsetFile(String infile, String outfile, List<Integer> columns, Long numCases,
         String delimiter) {
         try (FileInputStream fis = new FileInputStream(new File(infile))) {
@@ -90,6 +92,7 @@ public void subsetFile(String infile, String outfile, List<Integer> columns, Lon
     }
 
 
+    @Override
     public void subsetFile(InputStream in, String outfile, List<Integer> columns, Long numCases,
         String delimiter) {
           try (Scanner scanner = new Scanner(in); BufferedWriter out = new BufferedWriter(new FileWriter(outfile))) {

src/main/java/edu/harvard/iq/dataverse/engine/command/impl/AbstractSubmitToArchiveCommand.java

@@ -106,6 +106,7 @@ String getDataCiteXml(DatasetVersion dv) {
     public Thread startBagThread(DatasetVersion dv, PipedInputStream in, DigestInputStream digestInputStream2,
             String dataciteXml, ApiToken token) throws IOException, InterruptedException {
         Thread bagThread = new Thread(new Runnable() {
+            @Override
             public void run() {
                 try (PipedOutputStream out = new PipedOutputStream(in)) {
                     // Generate bag

src/main/java/edu/harvard/iq/dataverse/engine/command/impl/CreateNewDatasetCommand.java

@@ -136,6 +136,7 @@ protected void postPersist(Dataset theDataset, CommandContext ctxt) {
      * that a new dataset exists. 
      * NB: Needs dataset id so has to be postDBFlush (vs postPersist())
      */
+    @Override
     protected void postDBFlush(Dataset theDataset, CommandContext ctxt) {
         if (ctxt.settings().isTrueForKey(SettingsServiceBean.Key.SendNotificationOnDatasetCreation, false)) {
         //QDR - alert curators that a dataset has been created

src/main/java/edu/harvard/iq/dataverse/engine/command/impl/DuraCloudSubmitToArchiveCommand.java

@@ -116,6 +116,7 @@ public WorkflowStepResult performArchiveSubmission(DatasetVersion dv, ApiToken t
                         // Add datacite.xml file
 
                         Thread dcThread = new Thread(new Runnable() {
+                            @Override
                             public void run() {
                                 try (PipedOutputStream dataciteOut = new PipedOutputStream(dataciteIn)) {
 

src/main/java/edu/harvard/iq/dataverse/engine/command/impl/GoogleCloudSubmitToArchiveCommand.java

@@ -79,6 +79,7 @@ public WorkflowStepResult performArchiveSubmission(DatasetVersion dv, ApiToken t
                         // Add datacite.xml file
 
                         Thread dcThread = new Thread(new Runnable() {
+                            @Override
                             public void run() {
                                 try (PipedOutputStream dataciteOut = new PipedOutputStream(dataciteIn)) {
 

src/main/java/edu/harvard/iq/dataverse/harvest/server/web/servlet/OAIServlet.java

@@ -118,6 +118,7 @@ public class OAIServlet extends HttpServlet {
     private Repository xoaiRepository;
     private DataProvider dataProvider;
 
+    @Override
     public void init(ServletConfig config) throws ServletException {
         super.init(config);
 

src/main/java/edu/harvard/iq/dataverse/ingest/IngestMessageBean.java

@@ -66,6 +66,7 @@ public class IngestMessageBean implements MessageListener {
     public IngestMessageBean() {
     }
 
+    @Override
     @TransactionAttribute(TransactionAttributeType.NOT_SUPPORTED)
     public void onMessage(Message message) {
         IngestMessage ingestMessage = null;

src/main/java/edu/harvard/iq/dataverse/ingest/metadataextraction/impl/plugins/fits/FITSFileMetadataExtractor.java

@@ -224,6 +224,7 @@ public FITSFileMetadataExtractor() {
         super(null);
     }
 
+    @Override
     public FileMetadataIngest ingest(BufferedInputStream stream) throws IOException {
         dbgLog.fine("Attempting to read FITS file;");
 

src/main/java/edu/harvard/iq/dataverse/ingest/metadataextraction/impl/plugins/fits/FITSFileMetadataExtractorSpi.java

@@ -46,6 +46,7 @@ public FITSFileMetadataExtractorSpi() {
     }
 
 
+    @Override
     public String getDescription(Locale locale) {
         return "HU-IQSS-DVN-project FITS File Ingester";
     }

src/main/java/edu/harvard/iq/dataverse/ingest/metadataextraction/spi/FileMetadataExtractorSpi.java

@@ -45,6 +45,7 @@ public FileMetadataExtractorSpi(String vendorName, String version) {
         this.version = version;
     }
 
+    @Override
     public abstract String getDescription(Locale locale);
 
     protected String[] names = null;

src/main/java/edu/harvard/iq/dataverse/ingest/tabulardata/impl/plugins/csv/CSVFileReaderSpi.java

@@ -47,7 +47,8 @@ public CSVFileReaderSpi() {
     super("HU-IQSS-DVN-project", "0.1", formatNames, extensions, mimeType, CSVFileReaderSpi.class.getName());
   }
 
-  public String getDescription(Locale locale) {
+    @Override
+    public String getDescription(Locale locale) {
     return "HU-IQSS-Dataverse-project CSV";
   }
 

src/main/java/edu/harvard/iq/dataverse/ingest/tabulardata/impl/plugins/dta/DTAFileReaderSpi.java

@@ -95,6 +95,7 @@ public DTAFileReaderSpi() {
          dbgLog.fine("DTAFileReaderSpi is called");
     }
 
+    @Override
     public String getDescription(Locale locale) {
         return "HU-IQSS-DataVerse-project Stata File Ingest plugin";
     }

src/main/java/edu/harvard/iq/dataverse/ingest/tabulardata/impl/plugins/por/PORFileReaderSpi.java

@@ -502,6 +502,7 @@ public boolean canDecodeInput(File file) throws IOException {
         return false;
     }
 
+    @Override
     public String getDescription(Locale locale) {
         return "HU-IQSS-DataVerse-project SPSS/POR (\"portable\") File Ingest plugin";
     }

src/main/java/edu/harvard/iq/dataverse/ingest/tabulardata/impl/plugins/rdata/RDATAFileReaderSpi.java

@@ -49,7 +49,8 @@ public RDATAFileReaderSpi() {
     LOG.fine(RDATAFileReaderSpi.class.getName() + " is called");
   }
 
-  public String getDescription(Locale locale) {
+    @Override
+    public String getDescription(Locale locale) {
     return "HU-IQSS-DVN-project RDATA";
   }
 

src/main/java/edu/harvard/iq/dataverse/ingest/tabulardata/impl/plugins/sav/SAVFileReader.java

@@ -352,6 +352,7 @@ private void init() throws IOException {
         }
     }
 
+    @Override
     public TabularDataIngest read(BufferedInputStream stream, boolean storeWithVariableHeader, File dataFile) throws IOException {
         dbgLog.info("SAVFileReader: read() start");
 

src/main/java/edu/harvard/iq/dataverse/ingest/tabulardata/impl/plugins/sav/SAVFileReaderSpi.java

@@ -214,6 +214,7 @@ public boolean canDecodeInput(File file) throws IOException {
 
     /********/
 
+    @Override
     public String getDescription(Locale locale) {
         return "HU-IQSS-DataVerse-project SPSS/SAV File Ingest plugin";
     }

src/main/java/edu/harvard/iq/dataverse/ingest/tabulardata/impl/plugins/xlsx/XLSXFileReader.java

@@ -297,6 +297,7 @@ private SheetHandler(SharedStrings sst, DataTable dataTable, PrintWriter tempOut
             columnCount = 0;
         }
 
+        @Override
         public void startElement(String uri, String localName, String name,
                 Attributes attributes) throws SAXException {
             dbglog.fine("entering startElement (" + name + ")");
@@ -410,6 +411,7 @@ private String getColumnLetterTag(int columnCount) {
             return new String(letterTag);
         }
 
+        @Override
         public void endElement(String uri, String localName, String name)
                 throws SAXException {
             dbglog.fine("entering endElement (" + name + ")");

src/main/java/edu/harvard/iq/dataverse/ingest/tabulardata/impl/plugins/xlsx/XLSXFileReaderSpi.java

@@ -54,7 +54,8 @@ public XLSXFileReaderSpi() {
     LOG.fine(XLSXFileReaderSpi.class.getName() + " is called");
   }
 
-  public String getDescription(Locale locale) {
+    @Override
+    public String getDescription(Locale locale) {
     return "HU-IQSS-DVN-project Excel/XLSX";
   }
 

src/main/java/edu/harvard/iq/dataverse/pidproviders/AbstractPidProvider.java

@@ -148,6 +148,7 @@ protected String generateYear(DvObject dvObjectIn) {
         return dvObjectIn.getYearPublishedCreated();
     }
 
+    @Override
     public Map<String, String> getMetadataForTargetURL(DvObject dvObject) {
         logger.log(Level.FINE, "getMetadataForTargetURL");
         HashMap<String, String> metadata = new HashMap<>();
@@ -168,6 +169,7 @@ public boolean alreadyRegistered(DvObject dvo) throws Exception {
         return alreadyRegistered(globalId, false);
     }
 
+    @Override
     public abstract boolean alreadyRegistered(GlobalId globalId, boolean noProviderDefault) throws Exception;
 
     /*
@@ -235,6 +237,7 @@ private String generateDatasetIdentifier(Dataset dataset) {
      * @param dataset
      * @return {@code true} if the identifier is unique, {@code false} otherwise.
      */
+    @Override
     public boolean isGlobalIdUnique(GlobalId globalId) {
         if (!pidProviderService.isGlobalIdLocallyUnique(globalId)) {
             return false; // duplication found in local database
@@ -313,6 +316,7 @@ protected GlobalId parsePersistentId(String protocol, String identifierString) {
         return parsePersistentId(protocol, authority, identifier);
     }
 
+    @Override
     public GlobalId parsePersistentId(String protocol, String authority, String identifier) {
         logger.fine("Parsing: " + protocol + ":" + authority + getSeparator() + identifier + " in " + getId());
         if (!PidProvider.isValidGlobalId(protocol, authority, identifier)) {
@@ -342,6 +346,7 @@ public GlobalId parsePersistentId(String protocol, String authority, String iden
         return new GlobalId(protocol, authority, identifier, getSeparator(), getUrlPrefix(), getId());
     }
 
+    @Override
     public String getSeparator() {
         // The standard default
         return SEPARATOR;