-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renames #119
Merged
Merged
Renames #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnd0e
pushed a commit
to johnd0e/ingress-intel-total-conversion
that referenced
this pull request
Feb 28, 2019
Yes. By the way, i like "Player Activity Tracker" |
Mostly renamed just `@name` fields - Consistent capitalization - Consize @name, as it also serves as identifier (We have @description for more info) - Names begin with most meaningful word General verbs avoided (like 'show') Some files renamed too: ``` compute-ap-stats.user.js -> ap-stats.user.js cache-details-on-map.user.js -> cache-portals-on-map.user.js layer-farms-find.user.js -> farms-find.user.js portal-highlighter-forgotten.user.js -> highlight-forgotten.user.js portal-highlighter-hide-team.user.js -> highlight-hide-team.user.js portal-highlighter-high-level.user.js -> highlight-high-level.user.js portal-highlighter-infrastructure.user.js -> highlight-infrastructure.user.js portal-highlighter-level-color.user.js -> highlight-level-color.user.js portal-highlighter-missing-resonators.user.js -> highlight-missing-resonators.user.js portal-highlighter-needs-recharge.user.js -> highlight-needs-recharge.user.js portal-highlighter-ornaments.user.js -> highlight-ornaments.user.js portal-highlighter-portals-my-level.user.js -> highlight-portals-my-level.user.js portal-highlighter-weakness.user.js -> highlight-weakness.user.js show-linked-portals.css -> linked-portals-show.css show-linked-portals.user.js -> linked-portals-show.user.js guess-player-levels.user.js -> player-level-guess.user.js ```
Avoid too small or too big categories - remove `Keys` and `Debug` - new `Draw` category (separated from `Layer`) - some plugins were uncategorized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed plugins moved into
deleted
directory. I suppose it's better to not delete obsolete plugins' files completely, as it would be easier to track their history.N.B.
After this PR one-time action required: users have to delete renamed plugins before updating