Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renames #119

Merged
merged 14 commits into from
Mar 14, 2019
Merged

Renames #119

merged 14 commits into from
Mar 14, 2019

Conversation

johnd0e
Copy link
Contributor

@johnd0e johnd0e commented Feb 25, 2019

Removed plugins moved into deleted directory. I suppose it's better to not delete obsolete plugins' files completely, as it would be easier to track their history.

N.B.
After this PR one-time action required: users have to delete renamed plugins before updating

@johnd0e johnd0e added the WIP Work in progress || Proof of the concept label Feb 25, 2019
@johnd0e johnd0e removed the WIP Work in progress || Proof of the concept label Feb 26, 2019
johnd0e pushed a commit to johnd0e/ingress-intel-total-conversion that referenced this pull request Feb 28, 2019
@johnd0e
Copy link
Contributor Author

johnd0e commented Feb 28, 2019

There was old discussion: Rename "Player Tracker" plugin to "Activity Tracker" or "Player Activity Tracker" #892

@modos189
Should we rename it now?

@modos189
Copy link
Contributor

modos189 commented Mar 13, 2019

Should we rename it now?

Yes. By the way, i like "Player Activity Tracker"

johndoe added 14 commits March 14, 2019 17:35
Mostly renamed just `@name` fields
- Consistent capitalization
- Consize @name, as it also serves as identifier
  (We have @description for more info)
- Names begin with most meaningful word
  General verbs avoided (like 'show')

Some files renamed too:
```
  compute-ap-stats.user.js -> ap-stats.user.js
  cache-details-on-map.user.js -> cache-portals-on-map.user.js
  layer-farms-find.user.js -> farms-find.user.js
  portal-highlighter-forgotten.user.js -> highlight-forgotten.user.js
  portal-highlighter-hide-team.user.js -> highlight-hide-team.user.js
  portal-highlighter-high-level.user.js -> highlight-high-level.user.js
  portal-highlighter-infrastructure.user.js -> highlight-infrastructure.user.js
  portal-highlighter-level-color.user.js -> highlight-level-color.user.js
  portal-highlighter-missing-resonators.user.js -> highlight-missing-resonators.user.js
  portal-highlighter-needs-recharge.user.js -> highlight-needs-recharge.user.js
  portal-highlighter-ornaments.user.js -> highlight-ornaments.user.js
  portal-highlighter-portals-my-level.user.js -> highlight-portals-my-level.user.js
  portal-highlighter-weakness.user.js -> highlight-weakness.user.js
  show-linked-portals.css -> linked-portals-show.css
  show-linked-portals.user.js -> linked-portals-show.user.js
  guess-player-levels.user.js -> player-level-guess.user.js
```
Avoid too small or too big categories
- remove `Keys` and `Debug`
- new `Draw` category (separated from `Layer`)
- some plugins were uncategorized
@modos189 modos189 merged commit 844bbce into IITC-CE:master Mar 14, 2019
@johnd0e johnd0e deleted the renames branch March 15, 2019 08:22
@johnd0e johnd0e removed the ATTENTION Feedback required label Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants