Brushing over notebook #1470
Draft
Brushing over notebook #1470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on where possible. Thermodynamic more robust.
PaulJonasJost
requested review from
dilpath,
Doresic,
dweindl,
FFroehlich and
m-philipps
as code owners
…g to naming scheme in benchmark models as well
…according to naming scheme in benchmark models as well" This reverts commit a1a54f7.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1470 +/- ##
===========================================
- Coverage 83.44% 83.40% -0.04%
===========================================
Files 160 160
Lines 13502 13502
===========================================
- Hits 11267 11262 -5
- Misses 2235 2240 +5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly:
Hopefully closes #1460 and #1396