Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Attempt #1463 #1464

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Fix Attempt #1463 #1464

wants to merge 1 commit into from

Conversation

FFroehlich
Copy link
Contributor

see #1463

@FFroehlich FFroehlich marked this pull request as draft September 16, 2024 14:12
@FFroehlich FFroehlich changed the title attempt fix + add test Fix Attempt #1463 Sep 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.47%. Comparing base (5c58374) to head (5acf73a).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
pypesto/petab/importer.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1464      +/-   ##
===========================================
- Coverage    83.40%   82.47%   -0.94%     
===========================================
  Files          160      160              
  Lines        13499    13500       +1     
===========================================
- Hits         11259    11134     -125     
- Misses        2240     2366     +126     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FFroehlich
Copy link
Contributor Author

Looks like amici.petab.parameter_mapping.create_parameter_mapping is not generating the expected mapping. Needs further investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants