Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.5.0 #1342

Merged
merged 35 commits into from
Apr 13, 2024
Merged

Release v0.5.0 #1342

merged 35 commits into from
Apr 13, 2024

Conversation

PaulJonasJost
Copy link
Collaborator

@PaulJonasJost PaulJonasJost commented Mar 27, 2024

PaulJonasJost and others added 19 commits February 21, 2024 09:50
* Include pymc in the documentation.

* Moved Parameter description to correct place at init

* Moved extra information of text upwards.

* Added __all__ definition to pymc

* Update pypesto/sample/pymc.py

Co-authored-by: Daniel Weindl <[email protected]>

* Moved back docstring to attributes

---------

Co-authored-by: Daniel Weindl <[email protected]>
* add approx grad ipopt option

---------

Co-authored-by: Simon Merkt <[email protected]>
Co-authored-by: Paul Jonas Jost <[email protected]>
* Removed old python versions from black

* Replaced most precommit hooks for ruff.

* Changed to ruff. Currently only checking for F rules

* Solved F errors

* Solved I errors

* Solved D413 error

* Solved D errors. (Ignoring for example python files) with correct line length

* Included flake8-bandit

* Included flake8-bugbear

* Included flake8-comprehensions

* Included juypternotebooks, added pycodestyyle. Removed flake8 nd nbqa from pre-commits

* small formatting

* correct tmpfile handling

* Add D413 (blank line after last section) to ignore

* Removed non existing file from excludes

* Removed D107 from file specific, as it is in all files ignored

* Removed black and isort from pyproject.toml

* Revert D413

* removed flake8 and project from tox.removed .flake8

* fixed {} to dict()

* Added two missing notebooks to test.

* Removed depracated force_compile

* corrected workflow_comparison

* removed manual profiling from running and only as comment

* removed outputs

* removed workflow_comparison.ipynb

---------

Co-authored-by: Daniel Weindl <[email protected]>
* fix calc return if simulation failed

* Daniel review change

* Fix the extension
* PetabImporter checks for existing amici model in the location specified by output_folder before re-compiling.
* Add spline knots to the optimization result

Adds spline knots to the optimization result so they can be easily obtained after optimization. This then allows easy further use, if needed.

* Documentation update & fix notebook

* Fix types

* Daniel review change

Co-authored-by: Daniel Weindl <[email protected]>

* add test spline knot saving

* Update pypesto/visualize/spline_approximation.py

Co-authored-by: Maren Philipps <[email protected]>

---------

Co-authored-by: Daniel Weindl <[email protected]>
Co-authored-by: Maren Philipps <[email protected]>
* changed to new amici import format, removed some depracation warnings. Some are left, one needs to keep an eye out for probably.

* corrected to amici.petab.conditions.fill_in_parameters

* added minimal version to amici
Repeating the change made in #1313. Somehow it got overwritten to the old version.

Co-authored-by: Jonas Arruda <[email protected]>
* thermodynamic integration

* compute_log_evidence

* added constants in C.py

* thermodynamic integration not supported for adaptive PT

* adding logger for beta init
* added warnings to dynesty and support for posterior

* adapted objective in test to likelihood

* added string constants

* added objective type to dynesty in notebook
Currently model simulation is run twice, even when no sensitivities are requested and the optimal inner parameters could be applied directly.
…#1328)

Fixes an issue where ESSOptimizer would try to repeatedly perform a local search from the best known value, instead of trying other promising points, in case the initial local search yields a non-finite result.
`SacessOptimizer` is superior to `CESSOptimizer` and I wouldn't recommend using the latter. I think it's best to just remove it. No value, just extra maintenance effort. I don't think anybody was using it yet anyways, so this shouldn't actually be a breaking change for anybody.
* Fix return of inner parameters on objective call

* hierarchical_decorator outside of history_decorator

---------

Co-authored-by: Daniel Weindl <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 85.40541% with 216 lines in your changes are missing coverage. Please review.

Project coverage is 84.50%. Comparing base (34e89b3) to head (64f8205).

Files Patch % Lines
pypesto/visualize/sampling.py 52.63% 18 Missing ⚠️
...esto/objective/roadrunner/roadrunner_calculator.py 86.06% 17 Missing ⚠️
pypesto/optimize/optimizer.py 75.36% 17 Missing ⚠️
pypesto/sample/dynesty.py 72.58% 17 Missing ⚠️
.../objective/roadrunner/petab_importer_roadrunner.py 89.28% 15 Missing ⚠️
pypesto/visualize/spline_approximation.py 13.33% 13 Missing ⚠️
pypesto/objective/roadrunner/utils.py 91.40% 11 Missing ⚠️
pypesto/visualize/dimension_reduction.py 18.18% 9 Missing ⚠️
pypesto/visualize/ordinal_categories.py 0.00% 9 Missing ⚠️
pypesto/objective/jax/base.py 73.33% 8 Missing ⚠️
... and 34 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1342      +/-   ##
==========================================
- Coverage   84.54%   84.50%   -0.04%     
==========================================
  Files         153      157       +4     
  Lines       12456    12917     +461     
==========================================
+ Hits        10531    10916     +385     
- Misses       1925     2001      +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

PaulJonasJost and others added 10 commits March 29, 2024 11:39
* First working example

* temp fix

* tmp_fix 2

* Added petab testsuite. Currently everything aside from Preequilibration and InitialAssignments overwrites works.

* All except for one petab test working. I.e. functioning ss-computation

* Sped up computation for MODE_FUN. Two tests only pass unreliably, one test expectedly fails.

* Fixed error, where the conditions in edatas did not align with the parameter mappings

* Removed pandas calculation to dataframe from calculator, made stand alone function. Expected speedup: ~5-10x

* Added SolverOptions for roadrunner simulation and slightly more convenient way to interact with it.

* Some cleanup

* Added get_config. Skipping 0018 for now.

* Support MODE_RES correctly

* added petab testsuite to tox for roadrunner.

* added roadrunner dependency

* Case 0018 works now as well. Fixed a problem if not all observables were measured at all timepoints

* Review suggestions and sanity check on filling parameters and edata

* Removed "unscale_parameter" function. Considerably speed up model compilation.

* removed timepoints from edatas. Added to documentation

* Removed fill_replicates, as it is now possible with roadrunner. Also able to more conveniently setValues. Added newer version restriction to roadrunner.

* Added roadrunner to tox.ini docs.

* Added roadrunner to tox.ini base.

* Changed to use API token for deployment

* Added short docstring to each file

* Added more descriptive docstring.

* Reverted deploy changes, in favor of separate PR

* Update pypesto/objective/roadrunner/roadrunner_calculator.py

Co-authored-by: Daniel Weindl <[email protected]>

* Hopefully fixes doc build

* Removed name for type for correct docstring.

* Should fix docs now and also pandas warning

* typo in tox

* Integrated suggestions

* Added roadrunner to doc installation

---------

Co-authored-by: Daniel Weindl <[email protected]>
…t` (#1351)

Fixes `Ensemble.from_optimization_{history,endpoints}`, which incorrectly assumed that `OptimizerResult.id` is always convertible to `int`.

Closes #1349.
Use 'spawn' by default, but allow passing other start methods via `SacessOptimizer(..., mp_start_method=...)`.

Closes #1343.
Stop using deprecated type annotations and imports. Include ruff pyupgrade rules in pre-commit.
* Added deepcpy functionality and small test.

* Better test and better deepcopy

* Update pypesto/objective/roadrunner/road_runner.py

Co-authored-by: Daniel Weindl <[email protected]>

* Removed deepcopy from base function as it should be similar to defaultbehaviour.

* Also removed deepcopy functionality.

* Update test/base/test_roadrunner.py

Co-authored-by: Daniel Weindl <[email protected]>

---------

Co-authored-by: Daniel Weindl <[email protected]>
* fix #1337

* fix pure callback calls

* run test in 32bit and 64bit mode

* add vmap compatibility, remove second order support

* Update test_objective.py

* Apply suggestions from code review

Co-authored-by: Paul Jonas Jost <[email protected]>

* alter implementation, fix doc and extend tests

* Update test_objective.py

* expose inner x_names rather than allowing them to be set

* Update base.py

* Update test_objective.py

---------

Co-authored-by: Paul Jonas Jost <[email protected]>
Co-authored-by: Daniel Weindl <[email protected]>
* compute burn in for each chain

* using all chains to compute evidence
@PaulJonasJost PaulJonasJost self-assigned this Apr 9, 2024
* removed startpoint method from minimize as its depracated and per default in the problem.

* Changed offset to one that should definitely catch the warning and test for warning.

* When loading a problem, we expect a warning.

* Trust-exact cannot handle bounds is an expected warning here.

* If hess is not traced, no need to compute imo

* Revert last changes, instead expect additional warning.

* Better catching of warnings

* Catch warnings?

* Removed startpoint methods from functions, all were uniform.

* added match as parameter to pytest.warns

* Removed warning, is already tested elsewhere.
PaulJonasJost and others added 2 commits April 10, 2024 14:45
* Added a brief roadrunner example. to be extended.

* Added roadrunner into tox.ini for notebook 1

* Filled in hyperrefs

* Added missing hyperref

---------

Co-authored-by: Doresic <[email protected]>
* Add support for complex noise formulae

* Removed comment

* removed try...except in favor of if
@PaulJonasJost PaulJonasJost changed the title Release v0.4.3 Release v0.5.0 Apr 12, 2024
PaulJonasJost and others added 2 commits April 12, 2024 14:12
* Changelog and version change

* Updated changelog

* Updated CHANGELOG.rst
@PaulJonasJost PaulJonasJost marked this pull request as ready for review April 13, 2024 06:37
@PaulJonasJost PaulJonasJost merged commit 872e253 into main Apr 13, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants