Select: use petab_select method to set estimated parameters #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1287 +/- ##
============================================
- Coverage 79.16% 41.50% -37.67%
============================================
Files 153 153
Lines 12455 12455
============================================
- Hits 9860 5169 -4691
- Misses 2595 7286 +4691 ☔ View full report in Codecov by Sentry. |
dilpath
requested review from
Doresic,
PaulJonasJost and
m-philipps
as code owners
Doresic
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibly a breaking change, if users expect scaled values at
petab_select.Model.estimated_parameters, because PEtab Select stores unscaled parameters now.