feat(cf): support load cf config v4 or later #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* sync latest config data from upstream cf cli project * remove `LoggregatorEndpoint` property and corresponding codes * add `UAAGrantType` property, but not setter/getter * remove compatibility check and purge logic, we should delegate it to CF CLI * set default config version to `4` if not set * add unit test resolve #218
per discussion, we should clear out the config like cf cli, but only when the config version is not 3 or 4 1. add the applied change 2. fix and add unit test
weieigao
approved these changes
Sep 17, 2020
weieigao
reviewed
Sep 17, 2020
| @@ -49,7 +50,9 @@ func NewCFConfigData() *CFConfigData { | |||
| } | |||
|
|
|||
| func (data *CFConfigData) Marshal() ([]byte, error) { | |||
| data.ConfigVersion = 3 | |||
| if data.ConfigVersion == 0 { | |||
| data.ConfigVersion = 4 | |||
There was a problem hiding this comment.
maybe change to
if data.ConfigVersion != 3{
data.ConfigVersion = 4
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LoggregatorEndpointproperty and corresponding codesUAAGrantTypeproperty, but not setter/getterto CF CLI
4if not setresolve #218