Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support loading both v3 and v4 CF CLI config file #218

Open
archerzz opened this issue Sep 15, 2020 · 0 comments
Open

support loading both v3 and v4 CF CLI config file #218

archerzz opened this issue Sep 15, 2020 · 0 comments

Comments

@archerzz
Copy link
Contributor

Description

CF has bumped their CLI config data structure version to v4. Now we still assume we're loading v3 data, which will result in config data cleared when running any cf commands after ibmcloud target --cf. That is:

  1. we save cf config as v3.
  2. the user installed CF CLI version >= 6.52.0 which expects v4

See the issue in CF CLI: cloudfoundry/cli#2033

Resolution

We need to modify our implementation to:

  1. detect the version of CF CLI config data
  2. load the corresponding CF CLI config repoistory
@archerzz archerzz mentioned this issue Sep 15, 2020
Closed
4 tasks
archerzz pushed a commit that referenced this issue Sep 16, 2020
feat(cf): support load cf config v4 or later
2d2b94c 
* sync latest config data from upstream cf cli project
  * remove `LoggregatorEndpoint` property and corresponding codes
  * add `UAAGrantType` property, but not setter/getter
* remove compatibility check and purge logic, we should delegate it
  to CF CLI
* set default config version to `4` if not set
* add unit test

resolve #218
@archerzz archerzz mentioned this issue Sep 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@archerzz