규칙 관련 이슈 수정 #355
Merged
규칙 관련 이슈 수정 #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyejungg
approved these changes
Sep 9, 2023
| @@ -17,6 +15,5 @@ public class UpdateRuleRepresentRequestDto { | |||
|
|
|||
| @ApiModelProperty(value = "설정한 대표 규칙 id 리스트", example = "[1, 2, 3]") | |||
| @NotNull(message = "{rule.list.notNull}") | |||
| @Size(min = Constraint.RULE_LIST_MIN, message = "{rule.list.min}") | |||
There was a problem hiding this comment.
빈 배열로 들어오는 경우는 대표 규칙을 선택한 것을 모두 취소하고 싶은 경우인거죠?
그러면 API docs랑 그 저 min 저것도 지워야할것같아요!
There was a problem hiding this comment.
docs 는 수정했는데, min 은 다른 deprecated 예정 API 에서 아직 사용중인 곳들이 있어서 냅뒀습니다!
|
고생하셨습니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✒️ 관련 이슈번호
🔑 Key Changes
📢 To Reviewers