Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

피드백 관련 API 수정 및 통합 #352

Merged
merged 2 commits into from
Aug 6, 2023
Merged

피드백 관련 API 수정 및 통합 #352

merged 2 commits into from
Aug 6, 2023

Conversation

orijoon98
Copy link
Member

✒️ 관련 이슈번호

🔑 Key Changes

  1. 호미나라 피드백 보내기와, 탈퇴 피드백이 동일한 페이지로 전달되는 걸 깨달아서.. API 를 통합했습니다..
  2. 새로 만들었던 회원 탈퇴 피드백 API 를 삭제하고 기존 피드백 API 에서 분기처리해서 동작하도록 수정했습니다!
  3. 슬랙 채널명과 알림명, 변수명, 메서드명 전부 수정했어요!

📢 To Reviewers

  • 사용하지 않는 슬랙 채널 지우고, 피드백 알림 채널 이름 바꿔서 알림 관련 yml 수정있어요! 노션에 반영해뒀습니다!

@orijoon98 orijoon98 added 🐼 혁준 🐼 혁준이가 했다아~ 🔧 Fix 간단한 수정 labels Aug 6, 2023
@orijoon98 orijoon98 requested a review from hyejungg August 6, 2023 12:18
@orijoon98 orijoon98 self-assigned this Aug 6, 2023
hyejungg
hyejungg approved these changes Aug 6, 2023
View reviewed changes
Copy link
Member

@hyejungg hyejungg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니당 ! github 시크릿키에도 반영된거죠?! 👍

@orijoon98 orijoon98 merged commit 6602de4 into develop Aug 6, 2023
2 checks passed
@orijoon98 orijoon98 deleted the fix/#351 branch August 6, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyejungg hyejungg hyejungg approved these changes

Assignees

@orijoon98 orijoon98

Labels
🐼 혁준 🐼 혁준이가 했다아~ 🔧 Fix 간단한 수정
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

피드백 관련 API 수정 및 통합
2 participants
@orijoon98 @hyejungg