#344 [fix] 규칙 메인 조회에서 대표 규칙 여부 함께 전달하도록 수정 #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orijoon98
reviewed
Jul 31, 2023
Comment on lines
27
to
42
| public static RulesResponse of(List<Rule> rules, LocalDateTime now) { | ||
| List<RuleInfo> sortedRuleInfo = rules.stream() | ||
| .sorted(Rule::compareTo) | ||
| .map(rule -> RuleInfo.of(rule, now)).collect(Collectors.toList()); | ||
|
|
||
| Map<Boolean, List<RuleInfo>> ruleInfoMap = sortedRuleInfo.stream() | ||
| .collect(Collectors.partitioningBy(RuleInfo::isRepresent)); | ||
|
|
||
| List<RuleInfo> representRuleInfo = ruleInfoMap.get(true); | ||
| List<RuleInfo> nonRepresentRuleInfo = ruleInfoMap.get(false); | ||
|
|
||
| return RulesResponse.builder() | ||
| .rules(rules.stream() | ||
| .sorted(Rule::compareTo) | ||
| .map(rule -> RuleInfo.of(rule, now)).collect(Collectors.toList())) | ||
| .rules(Stream.concat(representRuleInfo.stream(), nonRepresentRuleInfo.stream()) | ||
| .collect(Collectors.toList())) | ||
| .build(); | ||
| } |
There was a problem hiding this comment.
오홍.. 처음보는 메서드들이 많네요! 신기합니당..
이 방식도 좋은데 아래와 같이 하면 코드 라인수를 좀 줄일 수 있을 것 같아서 의견 내봅니당!!
public static RulesResponse of(List<Rule> rules, LocalDateTime now) {
return RulesResponse.builder()
.rules(rules.stream()
.sorted(Rule::compareTo)
.map(rule -> RuleInfo.of(rule, now))
.collect(Collectors.toList())
.stream()
.sorted(Comparator.comparing(RuleInfo::isRepresent).reversed())
.collect(Collectors.toList()))
.build();
}
There was a problem hiding this comment.
오 stream 을 이을 생각은 못했네요.. 좋습니당
orijoon98
approved these changes
Jul 31, 2023
hyejungg
added a commit
that referenced
this pull request
Aug 2, 2023
hyejungg
added a commit
that referenced
this pull request
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✒️ 관련 이슈번호
🔑 Key Changes
📢 To Reviewers