Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

swiftrsrc 1.0 (new formula) #36898

Closed
wants to merge 1 commit into from
Closed

Conversation

klaaspieter
Copy link

Add Swiftrsrc.

Issue: indragiek/swiftrsrc#1

sha1 "7fd484e0710c776a294896d93a2ee66c63069018"

depends_on "carthage" => :build

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

depends_on :macos => :mavericks as well, from the release page notes. Potentially that's actually an xcode version requirement though, rather than a MacOS version requirement?

@tdsmith
Copy link
Contributor

tdsmith commented Mar 3, 2015

Instead of using carthage checkout this should explicitly stage any needed dependencies into buildpath as resources; v8.rb gives an example.

You don't need to "run tests" in the test block but it would be nice to give swiftsrc some sample input and make sure it doesn't segfault processing it; cmake.rb has an example of a good test.

@adamv
Copy link
Contributor

adamv commented Mar 3, 2015

Note: this project may still be "too new" according to our acceptable formula guidelines

@DomT4
Copy link
Member

DomT4 commented Jun 16, 2015

This is popular enough to go into the core, but please address Tim's comments on vendoring deps and fix anything highlighted by brew audit --strict, Thanks!

@DomT4
Copy link
Member

DomT4 commented Jun 30, 2015

This seems to have gone dead. Closing consequently.

If you pick up interest later please feel free to resubmit as a new PR with the comments above addressed, Thanks!

Thank you for the submission!

@DomT4 DomT4 closed this Jun 30, 2015
@Homebrew Homebrew locked and limited conversation to collaborators Jul 11, 2016
@klaaspieter klaaspieter deleted the swiftrsrc branch April 3, 2018 12:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants