Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipx 0.14.0.0 #40300

Closed
wants to merge 1 commit into from
Closed

pipx 0.14.0.0 #40300

wants to merge 1 commit into from

Conversation

chenrui333
Copy link
Member

No description provided.

@zbeekman
Copy link
Contributor

zbeekman commented May 25, 2019

@AlJohri Any thoughts here?

(See 👇)

@zbeekman
Copy link
Contributor

==> /usr/local/Cellar/pipx/0.13.1.1/bin/pipx --help
Traceback (most recent call last):
  File "/usr/local/Cellar/pipx/0.13.1.1/libexec/bin/pipx", line 6, in <module>
    from pkg_resources import load_entry_point
  File "/usr/local/lib/python3.7/site-packages/pkg_resources/__init__.py", line 3191, in <module>
    @_call_aside
  File "/usr/local/lib/python3.7/site-packages/pkg_resources/__init__.py", line 3175, in _call_aside
    f(*args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/pkg_resources/__init__.py", line 3204, in _initialize_master_working_set
    working_set = WorkingSet._build_master()
  File "/usr/local/lib/python3.7/site-packages/pkg_resources/__init__.py", line 583, in _build_master
    ws.require(__requires__)
  File "/usr/local/lib/python3.7/site-packages/pkg_resources/__init__.py", line 900, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/usr/local/lib/python3.7/site-packages/pkg_resources/__init__.py", line 786, in resolve
    raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'userpath' distribution was not found and is required by pipx
Error: pipx: failed
An exception occurred within a child process:
  Test::Unit::AssertionFailedError: <0> expected but was
<1>.

@chenrui333
Copy link
Member Author

Seems like dep missing.
pkg_resources.DistributionNotFound: The 'userpath' distribution was not found and is required by pipx

@zbeekman
Copy link
Contributor

@chenrui333 original PR author for pipx, @AlJohri, said they would submit a formula for userpath, but then never did. It looks like they've now decided to make it mandatory, for better or worse.

I think userpath could be a nice addition to homebrew, so we may need a formula for it to continue supporting pipx.

@zbeekman
Copy link
Contributor

Alternatively, it appears to be a python package so it may be possible to just vendor it with pipx. (This may defeat the point of their desire to use it though...)

@AlJohri
Copy link
Contributor

AlJohri commented May 25, 2019

Yeah this is blocked from merging until this userpath issue is resolved. I will update this issue when that is complete. cc @ofek @jaraco @cs01

@jaraco
Copy link

jaraco commented May 25, 2019

There may be other ways to unblock this change:

  • include 'userpath' in the pipx homebrew install until it becomes its own recipe
  • build/install pipx using pip so that the executable isn't reliant on pkg_resources so bypasses the dependency check on invocation (as it is an optional dependency for the command-line).

@jaraco
Copy link

jaraco commented May 25, 2019

Are there any Homebrew formulas that use pip to install packages? If not, that's probably something that Homebrew should supply sooner than later as setup.py install is being deprecated (and doesn't support installation of newer PEP 517 style packages). I realize that's a broader concern outside the scope of this ticket. I'd be happy to consult on supporting that change.

@AlJohri
Copy link
Contributor

AlJohri commented May 25, 2019

@jaraco there's no issue with creating the formula. I've pretty much finished it here: ofek/userpath#4

Just need to resolve the issues with userpath itself: ofek/userpath#6

@zbeekman
Copy link
Contributor

Are there any Homebrew formulas that use pip to install packages?

Sure, I think docker-compose.rb is an OK example: brew cat docker-compose

We used to require pip packages be vendored, but no longer, so long as the appropriate flags are passed to pip (i.e., don't install binaries, etc.)

@zbeekman zbeekman added help wanted Task(s) needing PRs from the community or maintainers python Python use is a significant feature of the PR or issue labels May 25, 2019
@ofek
Copy link
Contributor

ofek commented Jul 13, 2019

FYI ofek/userpath#6 is now merged and released on PyPI as version 1.2.0 😄

@AlJohri
Copy link
Contributor

AlJohri commented Jul 18, 2019

@chenrui333 I found a bunch of issues using pipx through a virtualenv- any reason you changed that part of the formula?

I think the next step is creating the userpath homebrew formula (ofek/userpath#4) and then making pipx depends_on: "userpath".

Is that still the case @ofek?

@chenrui333
Copy link
Member Author

I think I did the virtualenv installation per the discussion in this thread, I can revert the change on that part. Let me know which way works.

@ofek
Copy link
Contributor

ofek commented Jul 18, 2019

@AlJohri Yes, would you like to make the PR?

@AlJohri
Copy link
Contributor

AlJohri commented Jul 18, 2019

@chenrui333 yes, I found issues when putting it in a virtualenv: pypa/pipx#60

can you revert that?

@ofek yes, let me submit the userpath formula now. I have not gotten a chance to test the latest changes but I trust it all works. 👍

@chenrui333
Copy link
Member Author

@AlJohri, @ofek I have reverted my changes to the original PR. :)

@chenrui333 chenrui333 changed the title pipx 0.13.1.1 pipx 0.14.0.0 Aug 10, 2019
@goranmoomin
Copy link
Contributor

Any updates on this? Is it still pending due to the userpath formula?

@Moisan
Copy link
Member

Moisan commented Sep 16, 2019

@BrewTestBot test this please

Co-authored-by: Thierry Moisan <[email protected]>
Co-authored-by: Jonathan Chang <[email protected]>
@jonchang
Copy link
Contributor

I just pushed up a new commit to try to get this merged.

  • dropping the virtualenv stuff for a manual python install (c.f. homebrew? pypa/pipx#60)
  • only linking the pipx binary since that was causing weird conflicts w/ other formulae

@jonchang jonchang added ready to merge PR can be merged once CI is green and removed help wanted Task(s) needing PRs from the community or maintainers labels Sep 24, 2019
@Moisan Moisan closed this in 8b5c209 Sep 24, 2019
@lock lock bot added the outdated PR was locked due to age label Jan 8, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 8, 2020
@chenrui333 chenrui333 deleted the pipx-0.13.1.1 branch December 18, 2022 04:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age python Python use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants