-
-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pipx 0.14.0.0 #40300
pipx 0.14.0.0 #40300
Conversation
@AlJohri Any thoughts here? (See 👇) |
|
Seems like dep missing. |
@chenrui333 original PR author for pipx, @AlJohri, said they would submit a formula for userpath, but then never did. It looks like they've now decided to make it mandatory, for better or worse. I think userpath could be a nice addition to homebrew, so we may need a formula for it to continue supporting pipx. |
Alternatively, it appears to be a python package so it may be possible to just vendor it with pipx. (This may defeat the point of their desire to use it though...) |
There may be other ways to unblock this change:
|
Are there any Homebrew formulas that use pip to install packages? If not, that's probably something that Homebrew should supply sooner than later as |
@jaraco there's no issue with creating the formula. I've pretty much finished it here: ofek/userpath#4 Just need to resolve the issues with userpath itself: ofek/userpath#6 |
Sure, I think docker-compose.rb is an OK example: We used to require pip packages be vendored, but no longer, so long as the appropriate flags are passed to |
FYI ofek/userpath#6 is now merged and released on PyPI as version |
@chenrui333 I found a bunch of issues using pipx through a virtualenv- any reason you changed that part of the formula? I think the next step is creating the Is that still the case @ofek? |
I think I did the virtualenv installation per the discussion in this thread, I can revert the change on that part. Let me know which way works. |
@AlJohri Yes, would you like to make the PR? |
@chenrui333 yes, I found issues when putting it in a virtualenv: pypa/pipx#60 can you revert that? @ofek yes, let me submit the userpath formula now. I have not gotten a chance to test the latest changes but I trust it all works. 👍 |
7df460e
to
236ee9a
Compare
b048606
to
31bf728
Compare
Any updates on this? Is it still pending due to the userpath formula? |
@BrewTestBot test this please |
3bbaedd
to
c3ff48e
Compare
Co-authored-by: Thierry Moisan <[email protected]> Co-authored-by: Jonathan Chang <[email protected]>
c3ff48e
to
589c7f4
Compare
I just pushed up a new commit to try to get this merged.
|
No description provided.