Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-remote-hg 0.3 (new formula) #3573

Closed

Conversation

DoomHammer
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?
  • Have you built your formula locally prior to submission with brew install <formula> (where <formula> is the name of the formula you're submitting)?
  • Does your submission pass brew audit --strict --online <formula> (after doing brew install <formula>)?

Nice bridge allowing use of familiar git commands with Mercurial repositories.

@MikeMcQuaid
Copy link
Member

Does your submission pass brew audit --strict --online (after doing brew install )?

It does not.

@DoomHammer
Copy link
Contributor Author

Might be discrepancies between Linuxbrew that I use and Homebrew. Will try to fix any problems.

@DoomHammer DoomHammer force-pushed the git-remote-hg-new-formula branch 3 times, most recently from 276edc6 to f951968 Compare August 3, 2016 14:13
@DoomHammer
Copy link
Contributor Author

It does, now. Sorry about that.

sha256 "2dc889b641d72f5a73c4c7d5df3b8ea788e75a7ce80f5884a7a8d2e099287dce"

depends_on :hg
depends_on :python
Copy link
Member

@DomT4 DomT4 Aug 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be:

depends_on :python if MacOS.version <= :snow_leopard

I believe, unless #3548 has an impact on other things that tie hg and Python together.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried this, but git-remote-hg needs python2 binary so this if unfortunately breaks things as seen in http://bot.brew.sh/job/Homebrew%20Core%20Pull%20Requests/5779/ . What's the best approach in such case?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that old chestnut. We inreplace out the python2 for python in that case. We do so already for src, duplicity, probably a fair few others.

@tdsmith Just to check, is there any risk mixing Python interpreters here, if we switch our mercurial to use our Python & this uses the system Python instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here.

@DomT4 DomT4 added the new formula PR adds a new formula to Homebrew/homebrew-core label Aug 3, 2016
depends_on :python if MacOS.version <= :snow_leopard

def install
inreplace "git-remote-hg", "python2", "python"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider reporting this to the upstream project.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can report it, but I believe this is done on purpose rather than as a mistake.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may well be but if they want to support OS X they should probably know that python2 isn't provided there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be surprised if they accept this to be honest. I believe on some Linux distros #!/usr/bin/env python points to python3 now whereas python2 is always "safe", so that's likely the reasoning.

OS X isn't particularly ahead of the curve. I tend to consider if a Apple bug rather than an upstream one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still worth asking I think; even if it's an Apple bug it's silly for all OS X package managers to have to patch this indefinitely.

Copy link
Contributor

@tdsmith tdsmith Aug 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW Apple does provide a python2.7 which is the only 2.x version worth using anyway.

@MikeMcQuaid
Copy link
Member

Thanks again @DoomHammer!

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants