elvis: add completions for Bash and Zsh #191810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
This needs to be combined with the version bump that actually brings the shell completion: by rebasing this PR branch after #191831 is merged. |
|
Re-started the checks now that #191831 was merged, so maybe even no rebasing is needed 🤞 |
|
Nah, it seems it must be rebased to use v3.2.6. |
branchvincent
force-pushed
the
feature/elvis-completion
branch
from
5873607
to
76054c9
Compare
|
🤖 An automated task has requested bottles to be published to this PR. |
github-actions
bot
added
the
CI-published-bottle-commits
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?Opening as draft, for now, since the Elvis version that'll contain the shell completions is not yet out (waiting on inaka/elvis#591). If all goes well, as was the case for #191632, for example, Elvis 3.2.5+ will get released soon, the formula will be auto-updated and then this pull request will go from Draft to Ready for review to merged almost (?) without intervention.