Skip to content

Commit

Permalink
tests: make tests compatible with both psycopg2 and 3
Browse files Browse the repository at this point in the history
  • Loading branch information
hartungstenio committed Aug 7, 2023
1 parent f47e9f3 commit bfa7d90
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 17 deletions.
6 changes: 0 additions & 6 deletions drf_extra_fields/fields.py
Original file line number Diff line number Diff line change
Expand Up @@ -254,12 +254,6 @@ def to_representation(self, value):
upper = value.upper
bounds = value._bounds

if bounds:
if lower is None and bounds[0] == "[":
bounds = "(" + bounds[1]
if upper is None and bounds[1] == "]":
bounds = bounds[0] + ")"

return {'lower': self.child.to_representation(lower) if lower is not None else None,
'upper': self.child.to_representation(upper) if upper is not None else None,
'bounds': bounds}
Expand Down
22 changes: 11 additions & 11 deletions tests/test_fields.py
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,7 @@ class DateTimeRangeSerializer(serializers.Serializer):

class DateRangeSerializer(serializers.Serializer):

range = DateRangeField(initial=DateRange(None, None))
range = DateRangeField(initial=DateRange(None, None, '()'))


class DateRangeWithAllowEmptyFalseSerializer(serializers.Serializer):
Expand Down Expand Up @@ -504,7 +504,7 @@ class TestIntegerRangeField(FieldValues):
(NumericRange(**{'lower': '1', 'upper': '2'}),
{'lower': 1, 'upper': 2, 'bounds': '[)'}),
(NumericRange(**{'empty': True}), {'empty': True}),
(NumericRange(), {'bounds': '()', 'lower': None, 'upper': None}),
(NumericRange(bounds='()'), {'bounds': '()', 'lower': None, 'upper': None}),
({'lower': '1', 'upper': 2, 'bounds': '[)'},
{'lower': 1, 'upper': 2, 'bounds': '[)'}),
({'lower': 1, 'upper': 2},
Expand Down Expand Up @@ -557,7 +557,7 @@ class TestIntegerRangeChildAllowNullField(FieldValues):
(NumericRange(**{'lower': '1', 'upper': '2'}),
{'lower': 1, 'upper': 2, 'bounds': '[)'}),
(NumericRange(**{'empty': True}), {'empty': True}),
(NumericRange(), {'bounds': '()', 'lower': None, 'upper': None}),
(NumericRange(bounds='()'), {'bounds': '()', 'lower': None, 'upper': None}),
({'lower': '1', 'upper': 2, 'bounds': '[)'},
{'lower': 1, 'upper': 2, 'bounds': '[)'}),
({'lower': 1, 'upper': 2},
Expand Down Expand Up @@ -596,7 +596,7 @@ class TestDecimalRangeField(FieldValues):
(NumericRange(**{'lower': '1.1', 'upper': '2'}),
{'lower': '1.1', 'upper': '2', 'bounds': '[)'}),
(NumericRange(**{'empty': True}), {'empty': True}),
(NumericRange(), {'bounds': '()', 'lower': None, 'upper': None}),
(NumericRange(bounds='()'), {'bounds': '()', 'lower': None, 'upper': None}),
({'lower': Decimal('1.1'), 'upper': "2.3", 'bounds': '[)'},
{'lower': "1.1", 'upper': "2.3", 'bounds': '[)'}),
({'lower': Decimal('1.1'), 'upper': "2.3"},
Expand Down Expand Up @@ -647,7 +647,7 @@ class TestDecimalRangeFieldWithChildAttribute(FieldValues):
(NumericRange(**{'lower': '1.1', 'upper': '2'}),
{'lower': '1.10', 'upper': '2.00', 'bounds': '[)'}),
(NumericRange(**{'empty': True}), {'empty': True}),
(NumericRange(), {'bounds': '()', 'lower': None, 'upper': None}),
(NumericRange(bounds='()'), {'bounds': '()', 'lower': None, 'upper': None}),
({'lower': Decimal('1.1'), 'upper': "2.3", 'bounds': '[)'},
{'lower': "1.10", 'upper': "2.30", 'bounds': '[)'}),
({'lower': Decimal('1.1'), 'upper': "2.3"},
Expand Down Expand Up @@ -690,7 +690,7 @@ class TestFloatRangeField(FieldValues):
(NumericRange(**{'lower': '1.1', 'upper': '2'}),
{'lower': 1.1, 'upper': 2, 'bounds': '[)'}),
(NumericRange(**{'empty': True}), {'empty': True}),
(NumericRange(), {'bounds': '()', 'lower': None, 'upper': None}),
(NumericRange(bounds='()'), {'bounds': '()', 'lower': None, 'upper': None}),
({'lower': '1', 'upper': 2., 'bounds': '[)'},
{'lower': 1., 'upper': 2., 'bounds': '[)'}),
({'lower': 1., 'upper': 2.},
Expand Down Expand Up @@ -760,7 +760,7 @@ class TestDateTimeRangeField(TestCase, FieldValues):
'bounds': '[)'}),
(DateTimeTZRange(**{'empty': True}),
{'empty': True}),
(DateTimeTZRange(),
(DateTimeTZRange(bounds='()'),
{'bounds': '()', 'lower': None, 'upper': None}),
({'lower': '2001-01-01T13:00:00Z',
'upper': '2001-02-02T13:00:00Z',
Expand All @@ -775,7 +775,7 @@ class TestDateTimeRangeField(TestCase, FieldValues):
'upper': '2001-02-02T13:00:00Z',
'bounds': '[)'}),
({'upper': '2001-02-02T13:00:00Z', 'bounds': '[)'},
{'lower': None, 'upper': '2001-02-02T13:00:00Z', 'bounds': '()'}),
{'lower': None, 'upper': '2001-02-02T13:00:00Z', 'bounds': '[)'}),
({'lower': '2001-01-01T13:00:00Z', 'bounds': '[)'},
{'lower': '2001-01-01T13:00:00Z', 'upper': None, 'bounds': '[)'}),
({}, {}),
Expand Down Expand Up @@ -838,7 +838,7 @@ class TestDateRangeField(FieldValues):
'bounds': '[)'}),
(DateRange(**{'empty': True}),
{'empty': True}),
(DateRange(), {'bounds': '()', 'lower': None, 'upper': None}),
(DateRange(bounds='()'), {'bounds': '()', 'lower': None, 'upper': None}),
({'lower': '2001-01-01',
'upper': '2001-02-02',
'bounds': '[)'},
Expand All @@ -852,9 +852,9 @@ class TestDateRangeField(FieldValues):
'upper': '2001-02-02',
'bounds': '[)'}),
({'upper': '2001-02-02', 'bounds': '[)'},
{'lower': None, 'upper': '2001-02-02', 'bounds': '()'}),
{'lower': None, 'upper': '2001-02-02', 'bounds': '[)'}),
({'lower': '2001-01-01', 'bounds': '[)'},
{'lower': '2001-01-01', 'upper': None, 'bounds': '[)'}),
{'lower': '2001-01-01', 'upper': None, 'bounds': '[)'}),
({}, {}),
]
field = DateRangeField()
Expand Down

0 comments on commit bfa7d90

Please sign in to comment.