Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When code signing, a connection to the Apple time servers is required. #249

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

digitalmoksha
Copy link
Contributor

If you’re building without an internet connection (airplane, train,
etc), then it can be impossible to build. Particularly when you need
to use code signing during development. Implemented the
codesign_disable_timestamp config variable to pass the
—timestamp=none flag to the codesign executable. Defaults
to false. Only for macOS at the moment.

If you’re building without an internet connection (airplane, train,
etc), then can be impossible to build.  Particularly when you need
to use code signing during development.  Implemented the
`codesign_disable_timestamp` config variable to pass the
`—timestamp=none` flag to the `codesign` executable.  Defaults
to false.  Only for macOS at the moment.
@lrz
Copy link
Member

lrz commented Jan 2, 2017

Thanks for the contribution! Should we set it to true when building in development mode?

@digitalmoksha
Copy link
Contributor Author

I suppose you could always disable the timestamp during development, and have it enabled for release. Which is basically what I'm doing now in my Rakefile. I don't really see a downside to that, as long as it's enabled for the release build. Then we wouldn't need the new flag.

@digitalmoksha
Copy link
Contributor Author

Changed the default based on the development flag, but left it as an option that can be set explicitly

@digitalmoksha
Copy link
Contributor Author

bump -- any hope of getting this merged in? I ran into this problem again with 4.18 when trying to build in a non-wifi situation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants