Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some updates and additions to the SAO sample #1149

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jcward
Copy link
Contributor

@jcward jcward commented May 30, 2023

Playing with the SAO sample project, I found the edges to be a bit harsh, and the shadows dark and a bit ugly. Some tweaking could make it much prettier. So I:

  • added an option to use the FXAA shader (on the color texture... I just copied what Pbr was doing, seems to work?)
  • added options to control the shadows parameters
  • reduced the default shadow power from 30 to 8, and quality from 0.5 to 1.0
  • moved the vsync option from keyboard V to checkbox
  • added keyboard shortcut hint
  • added an option to make addSlider only display and set integer values (for samples and shadow size)

Before:

Selection_1761

After:

image

@jcward
Copy link
Contributor Author

jcward commented Jun 7, 2023

Bump - any reason not to make the SAO example prettier / showcase more functionality? The only change to SampleApp.hx was to allow sliders the option to show only integers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant