Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up grammar and punctuation #234

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

ternera
Copy link

@ternera ternera commented Apr 30, 2024

I fixed some grammar and punctuation that was incorrect.

@iMartzen
Copy link
Member

iMartzen commented May 1, 2024

Hi @ternera ! Thanks for you MR and taking the time to make our repo better!
I reviewed it, can you respond to the questions? 👍

@ternera
Copy link
Author

ternera commented May 1, 2024

Hi @ternera ! Thanks for you MR and taking the time to make our repo better! I reviewed it, can you respond to the questions? 👍

Hi! Can you please specify which questions I should answer? Thank you.

@iMartzen
Copy link
Member

iMartzen commented May 13, 2024

Hi @ternera, See questions I've added during the review.

@ternera
Copy link
Author

ternera commented May 16, 2024

Hi @ternera, See questions I've added during the review.

Hello @iMartzen. I may be missing something, but it doesn't show on my end that you reviewed it.

@iMartzen
Copy link
Member

Can you try to find out about my review while using this documentation?: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/about-pull-request-reviews

I left a comment on the following:

  • sessions/mm/s01/mobile_hacking.md
  • sessions/mm/s02/industry_certificates.md

@ternera
Copy link
Author

ternera commented May 27, 2024

Can you try to find out about my review while using this documentation?: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/about-pull-request-reviews

I left a comment on the following:

  • sessions/mm/s01/mobile_hacking.md
  • sessions/mm/s02/industry_certificates.md

image
It says there are no conversations...

@iMartzen
Copy link
Member

image

Scroll down and see the comments I left.

@ternera
Copy link
Author

ternera commented Jun 15, 2024

They must be private or not available to me, because I do not see them.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants