Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quote plugin #123

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Quote plugin #123

wants to merge 13 commits into from

Commits on Feb 19, 2022

  1. Add a quote plugin with tests 

    Adds extra commands:
  - !quote <nick> [<pattern>]
  - !quote.list [<pattern>]                   # on a channel
  - !qote.list <channel> [<pattern>]  # in a privmsg
  - !quote.remove <id> [, <id>]*
    @bensimner @alanbriolat
    bensimner authored and alanbriolat committed Feb 19, 2022
    Configuration menu
    Copy the full SHA
    3884ab6 View commit details
    Browse the repository at this point in the history

  2. Clean up format to include quoteId 

    Also adds `!quotes * <pattern>`, for channel-wide quoting.
    @bensimner @alanbriolat
    bensimner authored and alanbriolat committed Feb 19, 2022
    Configuration menu
    Copy the full SHA
    679efdb View commit details
    Browse the repository at this point in the history

  3. Re-name some of the quote commands 

    Does some re-naming !quote -> !remember and !quotes -> !quote, also limits the use of !quote.list and !quote.remove to only authenticated users with the correct permissions.
    @bensimner @alanbriolat
    bensimner authored and alanbriolat committed Feb 19, 2022
    Configuration menu
    Copy the full SHA
    5df6db8 View commit details
    Browse the repository at this point in the history

  4. Change quoteId format to use [] rather than ()

    @bensimner @alanbriolat
    bensimner authored and alanbriolat committed Feb 19, 2022
    Configuration menu
    Copy the full SHA
    d67df91 View commit details
    Browse the repository at this point in the history

  5. Improve error messages

    @bensimner @alanbriolat
    bensimner authored and alanbriolat committed Feb 19, 2022
    Configuration menu
    Copy the full SHA
    e437f7c View commit details
    Browse the repository at this point in the history

  6. Clean up !quote.list to make it look nicer

    @bensimner @alanbriolat
    bensimner authored and alanbriolat committed Feb 19, 2022
    Configuration menu
    Copy the full SHA
    6271117 View commit details
    Browse the repository at this point in the history

  7. Add a reply on remembering 

    Also adds tests for the formatter
    @bensimner @alanbriolat
    bensimner authored and alanbriolat committed Feb 19, 2022
    Configuration menu
    Copy the full SHA
    4ad2f2e View commit details
    Browse the repository at this point in the history

  8. Reorganise quote plugin file to be more command-structured 

    Each @command is now a dispatch to a simpler function based off a regexp cli definition.
This could probably be formalised into a @command.group() decorator or something later.
    @bensimner @alanbriolat
    bensimner authored and alanbriolat committed Feb 19, 2022
    Configuration menu
    Copy the full SHA
    a989eee View commit details
    Browse the repository at this point in the history

  9. Remove redundant whitespace

    @bensimner @alanbriolat
    bensimner authored and alanbriolat committed Feb 19, 2022
    Configuration menu
    Copy the full SHA
    9a36680 View commit details
    Browse the repository at this point in the history

  10. Break Quote plugin into record and database types 

    Moving all the quote data into an attrs class makes it easier to work with over a dictionary.
Then hiding the database implementation as a mixin made the plugin class itself easier to understand.
    @bensimner @alanbriolat
    bensimner authored and alanbriolat committed Feb 19, 2022
    Configuration menu
    Copy the full SHA
    621e250 View commit details
    Browse the repository at this point in the history

  11. Remove identify_users 

    I'm not 100% sure what this was doing. I think we don't need it anymore.
    @bensimner @alanbriolat
    bensimner authored and alanbriolat committed Feb 19, 2022
    Configuration menu
    Copy the full SHA
    7a9e31f View commit details
    Browse the repository at this point in the history

  12. quote: modernise tests, upgrade to pymongo 4.x, get tests passing

    @alanbriolat
    alanbriolat committed Feb 19, 2022
    Configuration menu
    Copy the full SHA
    388fea8 View commit details
    Browse the repository at this point in the history

  13. quote: fix lint errors

    @alanbriolat
    alanbriolat committed Feb 19, 2022
    Configuration menu
    Copy the full SHA
    02af8e9 View commit details
    Browse the repository at this point in the history