fix(challenges): filter out groups without perms

HabitRPG · Aug 19, 2023 · 474fa53 · 474fa53
1 parent 2803db7
commit 474fa53
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/website/client/src/components/challenges/challengeModal.vue b/website/client/src/components/challenges/challengeModal.vue
@@ -418,6 +418,9 @@ export default {
   methods: {
     async shown () {
       this.groups = await this.$store.dispatch('guilds:getMyGuilds');
+      this.groups = this.groups.filter(group => !(
+        group.leaderOnly.challenges && group.leader !== this.user._id
+      ));
 
       if (this.user.party && this.user.party._id) {
         await this.$store.dispatch('party:getParty');

diff --git a/website/server/controllers/api-v3/groups.js b/website/server/controllers/api-v3/groups.js
@@ -321,7 +321,7 @@ api.getGroups = {
       throw new BadRequest(apiError('guildsOnlyPaginate'));
     }
 
-    const groupFields = basicGroupFields.concat(' description memberCount balance');
+    const groupFields = basicGroupFields.concat(' description memberCount balance leaderOnly');
     const sort = '-memberCount';
 
     const filters = {};