Implemented size checking in make-picture #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think these will run through now if you rebase. |
If the size requested is too high, one can no more create the picture. This avoids distorded picture, waiting for a proper implementation for huge pictures.
EdwardMoyse
force-pushed
the
sponce_sizeLimitInPngs
branch
from
884f40e
to
ef964fd
Compare
|
I had to actually fix the test - it wasn't running, but should be good now (though I'm not sure my fix was the best approach). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the size requested is too high, one can no more create the picture. This avoids distorded picture, waiting for a proper implementation for huge pictures.
This implements the first point of #581