Reuse of the same image with different sized displays causes a random resize. #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the image itself will cause the same image to be overwritten time and time again if you redo the resize for another screen... resulting in an ever changing image size. This change undoes that and the new ImageOps feature will speed up the image processing compared to the orignal without sacrificing the quality too much.
dgomes
approved these changes
Aug 14, 2024
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the same image source more then once, using a md5 hash of the image itself will cause the same image to be overwritten time and time again if you redo the resize for another screen... resulting in an ever changing image size.
This change fixes that and the resize function replacement ImageOps.fit will speed up the image processing compared to the original without sacrificing the quality too much, while preserving the aspect ratios.