Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run the build inside docker #1786

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

Mohmn
Copy link
Member

@Mohmn Mohmn commented Jun 5, 2024

Description

Fixes #1782 #1785

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Before After
"screenshot before" "screenshot after"

How Has This Been Tested?

  • Cypress integration
  • Cypress component tests
  • Jest unit tests

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Mohmn
Copy link
Member Author

Mohmn commented Jun 5, 2024

@dadiorchen i haved pushed the fix , but havent tested them, plz test the changes before merging them

@dadiorchen
Copy link
Collaborator

@Mohmn thanks!

@dadiorchen dadiorchen merged commit ce1f5f1 into Greenstand:main Jun 13, 2024
3 checks passed
Copy link

🎉 This PR is included in version 2.9.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploying to prod seems doing npm build
2 participants