Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(turborepo): add TurboRepo to the project #1739

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LifeAsDev
Copy link

Description

feature #1737

Fixes # (issue)

Type of change

Build
comment: # 'Please delete options that are not relevant.'

  • [ x] New feature (non-breaking change which adds functionality)
  • [ x] This change requires a documentation update

Screenshots

Before After
"screenshot before" "screenshot after"

How Has This Been Tested?

  • Cypress integration
  • Cypress component tests
  • Jest unit tests

Checklist:

  • [x ] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [x ] My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@dadiorchen
Copy link
Collaborator

wow, this is amazing! Thank you! @LifeAsDev

@dadiorchen
Copy link
Collaborator

@LifeAsDev how about the performance of compile the first page? Home page

@dadiorchen
Copy link
Collaborator

@LifeAsDev are you interested in joining our community on slack? If you do, please leave you email so I can invite you

@LifeAsDev
Copy link
Author

45seg without turbo, 11seg with turbo
Yeah I wanna join on the community [email protected]

@dadiorchen
Copy link
Collaborator

@LifeAsDev I have invited you from slack

@dadiorchen
Copy link
Collaborator

I tried this, maybe the major benefits for this is re-arrange the packet building for npm. For the next.js running, it seems not faster than npm, but one thing is the next time to run the app, the compiling time is reduced, but even so, the improvement of this tool is not big.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants