Merge pull request #388 from XLPeng57/#140-transfer-to-same-wallet

fix: check if the sender wallet is the same as the receiver wallet
Greenstand · Aug 6, 2023 · 2a27d91 · 2a27d91
2 parents 9ddaf4e + 6d2826b
commit 2a27d91
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/server/services/TransferService.js b/server/services/TransferService.js
@@ -39,6 +39,14 @@ class TransferService {
     // begin transaction
     try {
       await this._session.beginTransaction();
+
+      if (transferBody.sender_wallet === transferBody.receiver_wallet) {
+        throw new HttpError(
+          422,
+          'Cannot transfer to the same wallet as the originating one!',
+        );
+      }
+
       const walletSender = await this._walletService.getByIdOrName(
         transferBody.sender_wallet,
       );