Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate iframe absolute offset relative to viewport when determining target #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RichardALeon
Copy link

While trying to add the editor to a webpage where it would be located somewhere other than the document origin, I began to encounter issues dragging blocks into the editor, where they seemingly would only register if I hovered my finger around the bottom of the screen.

Some investigating demonstrated that this was because the _getTarget function attempts to use the iframe's absolute offset within the document when trying to determine which element within is being selected/focused. This offset is then subtracted from the coordinates of the touchpoint from the event. However, it appears that the event's coordinates are calculated in terms of an offset from viewport rather than an offset from the document origin.

After making this change, I no longer encountered issues with dragging blocks into the editor on my page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant