Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference link changed from expired github link to helm documentation link #600

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reference link changed from expired github link to helm documentation link #600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/building-deployer-helm.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ file is that values from the upstream chart can be respecified here.
For example, to override `wordpressUsername`, this top level values
file can specify a new value for `wordpress.wordpressUsername`.
For more details, see helm's
[documentation](https://github.com/helm/helm/blob/master/docs/chart_template_guide/subcharts_and_globals.md#overriding-values-from-a-parent-chart).
[documentation](https://helm.sh/docs/chart_template_guide/subcharts_and_globals#overriding-values-from-a-parent-chart).

Run the following helm command to download the wordpress chart.

Expand Down Expand Up @@ -313,7 +313,7 @@ See this [document](schema.md) for more references.
### Declare RBAC requirements (and disable RBAC in the chart)

While helm
[recommends](https://github.com/helm/helm/blob/master/docs/chart_best_practices/rbac.md)
[recommends](https://helm.sh/docs/chart_best_practices/rbac)
that charts should create RBAC resources by default, Marketplace
requires that charts __must not__ create k8s service accounts or
RBAC resources.
Expand Down