Add Spanner functionality to store and retrieve daily UMA metrics #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change builds on the landed schema changes in #665. Background: This change adds functionality store daily metrics from UMA export server. To prevent redundant requests, we also store a capstone (similar to ChromeStatus). The capstone lets us know if we already processed data from the UMA server for a given day. Table: DailyChromiumHistogramMetrics - Implements the writeableEntityMapper interface - Exposes one method: - UpsertDailyChromiumHistogramMetric - to upsert the metric for a given histogram enum value Table: DailyChromiumHistogramEnumCapstones - Implements the writeableEntityMapper interface - Exposes two methods: - HasDailyChromiumHistogramCapstone - to check if the metrics for a given day have already been processed. - UpsertDailyChromiumHistogramCapstone - for inserting the capstone for a given day. Part of splitting up #616
jrobbins
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change builds on the landed schema changes in #665.
Background:
This change adds functionality store daily metrics from UMA export server. To prevent redundant requests, we also store a capstone (similar to ChromeStatus). The capstone lets us know if we already processed data from the UMA server for a given day.
Table: DailyChromiumHistogramMetrics
Table: DailyChromiumHistogramEnumCapstones
Part of splitting up #616