Fetch and parse histogram enum files #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcscottiii
force-pushed
the
jcscottiii/go-modules
branch
from
eaf7c54
to
29cad4e
Compare
jcscottiii
force-pushed
the
jcscottiii/chromium-enum-workflow
branch
from
6750356
to
0b2e29c
Compare
jcscottiii
force-pushed
the
jcscottiii/go-modules
branch
from
29cad4e
to
8ba2884
Compare
jcscottiii
force-pushed
the
jcscottiii/chromium-enum-workflow
branch
from
0b2e29c
to
adfb3be
Compare
dlaliberte
approved these changes
Sep 18, 2024
Add logic to: 1. Fetch enums from the chromium codesearch - Similar to 2. Parse the data into our metricdatatypes.HistogramMapping This fetch and parse logic is inspired by ChromeStatus's [1](https://github.com/GoogleChrome/chromium-dashboard/blob/f367dd0690b857c85453c67f9d388f2b08797e6c/internals/fetchmetrics.py#L253-L282). Part of split up of #616 Parent PR: #668
jcscottiii
force-pushed
the
jcscottiii/chromium-enum-workflow
branch
from
cd06235
to
d761f7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add logic to:
This fetch and parse logic is inspired by
ChromeStatus's logic.
Part of split up of #616
Parent PR: #669