Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Fix broken RSS feeds #10424

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Fix broken RSS feeds #10424

merged 1 commit into from
Sep 29, 2023

Conversation

tunetheweb
Copy link
Member

@tunetheweb tunetheweb commented Sep 29, 2023

Changes proposed in this pull request:

  • Fixes broken RSS feed for feedly. as reported by several users.

It looks like they don't accept type="text/html" anymore. The spec specifies we should be using "html" anyway. Doesn't look like we changed anything here, so maybe something changed at Feedly's end?

FYI, this was originally changed too text/html in #5873 but with no explanation why. D.C.C still uses "html"

Prod (and recent other staging URLs) has this on Feedly:

image

This branch's preview has this on Feedly:

image

@netlify
Copy link

netlify bot commented Sep 29, 2023

Deploy Preview for web-dev-staging ready!

Name Link
🔨 Latest commit 5de5100
🔍 Latest deploy log https://app.netlify.com/sites/web-dev-staging/deploys/65170264fdfdb40008cc2b3f
😎 Deploy Preview https://deploy-preview-10424--web-dev-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tomayac
Copy link
Member

tomayac commented Sep 29, 2023

The mode=escaped thing doesn't really seem defined. Maybe move to <![CDATA[…]]> now that you touch the code? Also: 3> for doing this in the first place.

@tunetheweb
Copy link
Member Author

Agreed, but kinda keeping changes to a minimal for... well reasons I'm sure you understand :-)

@matthiasrohmer matthiasrohmer merged commit f5086ad into main Sep 29, 2023
10 checks passed
@matthiasrohmer matthiasrohmer deleted the fix-rss-feeds branch September 29, 2023 17:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants