Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases/semver #47

Open
tomchadwin opened this issue Jun 3, 2020 · 4 comments
Open

Releases/semver #47

tomchadwin opened this issue Jun 3, 2020 · 4 comments

Comments

@tomchadwin
Copy link
Contributor

tomchadwin commented Jun 3, 2020

Would you consider using numbered releases? I just tried to bump the copy of bridgestyle I use in qgis2web to current master (to try to fix qgis2web/qgis2web#895), and changes since 13 May have stopped point layers working for me (QGIS > MBGLJS). I don't yet know why, but the output from the bumped bridgestyle looks very different to what it was.

@tomchadwin
Copy link
Contributor Author

tomchadwin commented Jun 3, 2020

Current master:

{
    "version": 8,
    "glyphs": "mapbox://fonts/mapbox/{fontstack}/{range}.pbf",
    "name": "airports",
    "sources": {
        "vector-source": {
            "type": "vector",
            "tiles": [
                "URL to tiles - airports"
            ],
            "minZoom": 0,
            "maxZoom": 20
        }
    },
    "layers": [
        {
            "type": "symbol",
            "layout": {
                "icon-image": "circle-#279319-1.0-#000000-1.0-1",
                "icon-rotate": 0.0,
                "icon-size": 0.11160714285714285
            },
            "Z": 0,
            "source": "vector-source",
            "source-layer": "airports",
            "id": "airports:(rule#0):0"
        }
    ],
    "sprite": "spriteSheet"
}

Master as of 13 May:

{
    "version": 8,
    "name": "airports",
    "glyphs": "mapbox://fonts/mapbox/{fontstack}/{range}.pbf",
    "sources": {
        "airports": "TODO:Configure this!!!"
    },
    "layers": [
        {
            "type": "circle",
            "paint": {
                "circle-radius": [
                    "/",
                    7.5590551182,
                    2
                ],
                "circle-color": "#279319",
                "circle-opacity": 1.0,
                "circle-stroke-width": 1,
                "circle-stroke-color": "#000000"
            },
            "source": "airports",
            "id": ":0"
        }
    ],
    "sprite": "spriteSheet"
}

@tomchadwin
Copy link
Contributor Author

So I guess this change came about with this commit: f84ebf9. If I read this correctly, does this commit increase use of SVG markers, and decrease the use of MB style-defined symbols? If so, this might have unwanted consequences, such as the inability to change marker style properties via script.

@volaya
Copy link
Contributor

volaya commented Jun 10, 2020

Hi Tom, sorry for this. The change is to better support sprites (@davidblasby can probably give some more detail), and also to support several layers in a single style.

I guess we could publish the library in PyPi, and change the major version number whenever we introduce some changes in the API. Would that be OK for you?

@davidblasby
Copy link

yes - I added support for sprite and automatic generation of sprite sheets.

It supports a lot more of QGIS features now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants