Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn bridge-style into a proper Python package #62

Open
GeoSander opened this issue Sep 27, 2022 · 1 comment
Open

Turn bridge-style into a proper Python package #62

GeoSander opened this issue Sep 27, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@GeoSander
Copy link
Member

GeoSander commented Sep 27, 2022

Having a release on pypi would be great. To get there the imports need to change a little, but it would be very beneficial. For the user it shouldn't change at all.

Even if no release is published to pypi if the module system is adjusted as a proper python package then it would be possible for users to use the egg syntax to install this instead of using a git submodule, which is quite a terrible way of having a dependency:

pip install "git+https://github.com/GeoCat/bridge-style.git@519f8d2#egg=bridgestyle"

Originally posted by @categulario in #47 (comment)

@GeoSander
Copy link
Member Author

Hi @categulario, you are absolutely right and this is definitely something we should do.

Refactoring the repo as a proper package so you can properly use the egg syntax would be the preferred way for me, because I hate publishing something to PyPI that does not fully work out-of-the-box (i.e. because of the QGIS runtime dependency). However, we could make it super clear in the docs that QGIS/QML style conversions are not supported without a QGIS runtime of course.

Feel free to create a PR for this by the way, if you are bored. 🙂
I am occupied with other things at the moment...

@GeoSander GeoSander added the enhancement New feature or request label Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant