Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Vault): cast balance updates to uint96 #53

Merged
merged 1 commit into from
Oct 3, 2023
Merged

fix(Vault): cast balance updates to uint96 #53

merged 1 commit into from
Oct 3, 2023

Conversation

PierrickGT
Copy link
Contributor

Changes:

  • following the changes in the TwabController, balance updates have been updated to cast to uint96 instead of uint112

@linear
Copy link

linear bot commented Oct 2, 2023

GEN-736 Vault: update TWAB casting to uint96

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

LCOV of commit 48f90bc during coverage #305

Summary coverage rate:
  lines......: 96.7% (205 of 212 lines)
  functions..: 98.7% (74 of 75 functions)
  branches...: no data found

Files changed coverage rate:
                      |Lines       |Functions  |Branches    
  Filename            |Rate     Num|Rate    Num|Rate     Num
  ==========================================================
  src/Vault.sol       |96.6%    206|98.6%    73|    -      0

@PierrickGT PierrickGT force-pushed the gen-736-vault-update-twab-casting-to-uint96 branch from 48f90bc to cde015a Compare October 3, 2023 20:05
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

LCOV of commit cde015a during coverage #307

Summary coverage rate:
  lines......: 96.7% (205 of 212 lines)
  functions..: 98.7% (74 of 75 functions)
  branches...: no data found

Files changed coverage rate:
                      |Lines       |Functions  |Branches    
  Filename            |Rate     Num|Rate    Num|Rate     Num
  ==========================================================
  src/Vault.sol       |96.6%    206|98.6%    73|    -      0

@PierrickGT PierrickGT merged commit 6f8cb91 into main Oct 3, 2023
2 checks passed
@PierrickGT PierrickGT deleted the gen-736-vault-update-twab-casting-to-uint96 branch October 3, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@PierrickGT