Merge pull request #18 from GenerationSoftware/gen-592-clean-up-remai…

…ning-casting-in-twab-controller Removed some type casting detritus
GenerationSoftware · Aug 30, 2023 · e81e29c · e81e29c
2 parents 7c62ba6 + 4bf8870
commit e81e29c
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 61 deletions.
diff --git a/src/TwabController.sol b/src/TwabController.sol
@@ -656,7 +656,7 @@ contract TwabController {
       _vault,
       _currentDelegate,
       _to,
-      SafeCast.toUint96(userObservations[_vault][_from].details.balance)
+      SafeCast.toUint112(userObservations[_vault][_from].details.balance)
     );
 
     emit Delegated(_vault, _from, to);

diff --git a/src/libraries/OverflowSafeComparatorLib.sol b/src/libraries/OverflowSafeComparatorLib.sol
diff --git a/src/libraries/TwabLib.sol b/src/libraries/TwabLib.sol
@@ -3,8 +3,6 @@ pragma solidity ^0.8.19;
 
 import "ring-buffer-lib/RingBufferLib.sol";
 
-import { SafeCast } from "openzeppelin/utils/math/SafeCast.sol";
-import "./OverflowSafeComparatorLib.sol";
 import { ObservationLib, MAX_CARDINALITY } from "./ObservationLib.sol";
 
 /// @notice Emitted when a balance is decreased by an amount that exceeds the amount available.
@@ -49,7 +47,6 @@ error InsufficientHistory(uint48 requestedTimestamp, uint48 oldestTimestamp);
  *         within safe boundaries.
  */
 library TwabLib {
-  using OverflowSafeComparatorLib for uint32;
 
   /**
    * @notice Struct ring buffer parameters for single user Account.